From: David Miller <davem@davemloft.net>
To: jbohac@suse.cz
Cc: kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org,
kaber@trash.net, netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] IPv6: Drop the temporary address regen_timer
Date: Fri, 14 Oct 2016 10:59:33 -0400 (EDT) [thread overview]
Message-ID: <20161014.105933.75588707766999077.davem@davemloft.net> (raw)
In-Reply-To: <20161013165002.zn7wgjbacs34i73i@dwarf.suse.cz>
From: Jiri Bohac <jbohac@suse.cz>
Date: Thu, 13 Oct 2016 18:50:02 +0200
> The randomized interface identifier (rndid) was periodically updated from
> the regen_timer timer. Simplify the code by updating the rndid only when
> needed by ipv6_try_regen_rndid().
>
> This makes the follow-up DESYNC_FACTOR fix much simpler. Also it fixes a
> reference counting error in this error path, where an in6_dev_put was
> missing:
> err = addrconf_sysctl_register(ndev);
> if (err) {
> ipv6_mc_destroy_dev(ndev);
> - del_timer(&ndev->regen_timer);
> snmp6_unregister_dev(ndev);
> goto err_release;
>
> Signed-off-by: Jiri Bohac <jbohac@suse.cz>
Applied.
prev parent reply other threads:[~2016-10-14 14:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-13 16:50 [PATCH 1/2] IPv6: Drop the temporary address regen_timer Jiri Bohac
2016-10-14 14:59 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161014.105933.75588707766999077.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jbohac@suse.cz \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).