From: David Miller <davem@davemloft.net>
To: markus@trippelsdorf.de
Cc: eric.dumazet@gmail.com, ncardwell@google.com, netdev@vger.kernel.org
Subject: Re: [PATCH trivial] net: add bbr to config DEFAULT_TCP_CONG
Date: Fri, 14 Oct 2016 11:17:27 -0400 (EDT) [thread overview]
Message-ID: <20161014.111727.1347759995128120612.davem@davemloft.net> (raw)
In-Reply-To: <20161014080716.GA306@x4>
From: Markus Trippelsdorf <markus@trippelsdorf.de>
Date: Fri, 14 Oct 2016 10:07:16 +0200
> On 2016.10.14 at 09:43 +0200, Eric Dumazet wrote:
>> On Fri, 2016-10-14 at 09:33 +0200, Markus Trippelsdorf wrote:
>> > While playing with BBR I noticed that it was missing in the list of
>> > possible config DEFAULT_TCP_CONG choices. Fixed thusly.
>> >
>> > Signed-off-by: Markus Trippelsdorf <markus@trippelsdorf.de>
>> >
>> > diff --git a/net/ipv4/Kconfig b/net/ipv4/Kconfig
>> > index 300b06888fdf..b54b3ca939db 100644
>> > --- a/net/ipv4/Kconfig
>> > +++ b/net/ipv4/Kconfig
>> > @@ -715,6 +715,7 @@ config DEFAULT_TCP_CONG
>> > default "reno" if DEFAULT_RENO
>> > default "dctcp" if DEFAULT_DCTCP
>> > default "cdg" if DEFAULT_CDG
>> > + default "bbr" if DEFAULT_BBR
>> > default "cubic"
>>
>> Not sure if we want this at this moment.
>>
>> BBR needs FQ packet scheduler, and this is not exactly trivial to
>> achieve.
>
> For a start, it could be automatically selected:
Right but FQ has to be properly enabled and configured as well.
prev parent reply other threads:[~2016-10-14 15:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-14 7:33 [PATCH trivial] net: add bbr to config DEFAULT_TCP_CONG Markus Trippelsdorf
2016-10-14 7:43 ` Eric Dumazet
2016-10-14 8:07 ` Markus Trippelsdorf
2016-10-14 15:17 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161014.111727.1347759995128120612.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=markus@trippelsdorf.de \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).