From: David Miller <davem@davemloft.net>
To: timur@codeaurora.org
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] net: qcom/emac: disable interrupts before calling phy_disconnect
Date: Sat, 15 Oct 2016 17:35:06 -0400 (EDT) [thread overview]
Message-ID: <20161015.173506.1915898679977419991.davem@davemloft.net> (raw)
In-Reply-To: <1476472475-12104-1-git-send-email-timur@codeaurora.org>
From: Timur Tabi <timur@codeaurora.org>
Date: Fri, 14 Oct 2016 14:14:35 -0500
> There is a race condition that can occur if EMAC interrupts are
> enabled when phy_disconnect() is called. phy_disconnect() sets
> adjust_link to NULL. When an interrupt occurs, the ISR might
> call phy_mac_interrupt(), which wakes up the workqueue function
> phy_state_machine(). This function might reference adjust_link,
> thereby causing a null pointer exception.
>
> Signed-off-by: Timur Tabi <timur@codeaurora.org>
Applied.
prev parent reply other threads:[~2016-10-15 21:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-14 19:14 [PATCH] net: qcom/emac: disable interrupts before calling phy_disconnect Timur Tabi
2016-10-15 21:35 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161015.173506.1915898679977419991.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).