* [PATCH] net: hip04: Remove superfluous ether_setup after alloc_etherdev
@ 2016-10-17 7:22 Tobias Klauser
2016-10-17 14:32 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Tobias Klauser @ 2016-10-17 7:22 UTC (permalink / raw)
To: Yisen Zhuang, Salil Mehta; +Cc: netdev
There is no need to call ether_setup after alloc_ethdev since it was
already called there.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
---
drivers/net/ethernet/hisilicon/hip04_eth.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/hisilicon/hip04_eth.c b/drivers/net/ethernet/hisilicon/hip04_eth.c
index 3c99ca420f57..854befde0a08 100644
--- a/drivers/net/ethernet/hisilicon/hip04_eth.c
+++ b/drivers/net/ethernet/hisilicon/hip04_eth.c
@@ -897,7 +897,6 @@ static int hip04_mac_probe(struct platform_device *pdev)
INIT_WORK(&priv->tx_timeout_task, hip04_tx_timeout_task);
- ether_setup(ndev);
ndev->netdev_ops = &hip04_netdev_ops;
ndev->ethtool_ops = &hip04_ethtool_ops;
ndev->watchdog_timeo = TX_TIMEOUT;
--
2.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: hip04: Remove superfluous ether_setup after alloc_etherdev
2016-10-17 7:22 [PATCH] net: hip04: Remove superfluous ether_setup after alloc_etherdev Tobias Klauser
@ 2016-10-17 14:32 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2016-10-17 14:32 UTC (permalink / raw)
To: tklauser; +Cc: yisen.zhuang, salil.mehta, netdev
From: Tobias Klauser <tklauser@distanz.ch>
Date: Mon, 17 Oct 2016 09:22:04 +0200
> There is no need to call ether_setup after alloc_ethdev since it was
> already called there.
>
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Applied to net-next, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-10-17 14:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-17 7:22 [PATCH] net: hip04: Remove superfluous ether_setup after alloc_etherdev Tobias Klauser
2016-10-17 14:32 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).