From: David Miller <davem@davemloft.net>
To: stephen@networkplumber.org
Cc: dsa@cumulusnetworks.com, jiri@mellanox.com,
netdev@vger.kernel.org, dledford@redhat.com,
sean.hefty@intel.com, hal.rosenstock@gmail.com,
linux-rdma@vger.kernel.org, j.vosburgh@gmail.com,
vfalico@gmail.com, andy@greyhouse.net,
jeffrey.t.kirsher@intel.com, intel-wired-lan@lists.osuosl.org
Subject: Re: [PATCH net-next 02/11] net: Introduce new api for walking upper and lower devices
Date: Mon, 17 Oct 2016 10:42:00 -0400 (EDT) [thread overview]
Message-ID: <20161017.104200.2266025643403507437.davem@davemloft.net> (raw)
In-Reply-To: <20161017052121.2322279d@xeon-e3>
From: Stephen Hemminger <stephen@networkplumber.org>
Date: Mon, 17 Oct 2016 05:21:21 -0700
> You should write this more succinctly as:
>
> static bool __netdev_has_upper_dev(struct net_device *upper_dev, void *data)
> {
> struct net_device *dev = data;
>
> return upper_dev == dev;
> }
>
> bool netdev_has_upper_dev_all_rcu(struct net_device *dev,
> struct net_device *upper_dev)
> {
> return netdev_walk_all_upper_dev_rcu(dev,
> __netdev_has_upper_dev, upper_dev);
> }
>
> No if/else needed. No cast of void * ptr need. Use const if possible?
Agreed.
next prev parent reply other threads:[~2016-10-17 14:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-15 1:28 [PATCH v2 net-next 00/11] net: Fix netdev adjacency tracking David Ahern
2016-10-15 1:28 ` [PATCH net-next 04/11] IB/core: Flip to the new dev walk API David Ahern
2016-10-15 1:28 ` [PATCH net-next 08/11] rocker: " David Ahern
2016-10-15 1:28 ` [PATCH net-next 09/11] net: Remove all_adj_list and its references David Ahern
[not found] ` <1476494931-31813-1-git-send-email-dsa-qUQiAmfTcIp+XZJcv9eMoEEOCMrvLtNR@public.gmane.org>
2016-10-15 1:28 ` [PATCH net-next 01/11] net: Remove refnr arg when inserting link adjacencies David Ahern
2016-10-15 1:28 ` [PATCH net-next 02/11] net: Introduce new api for walking upper and lower devices David Ahern
[not found] ` <1476494931-31813-3-git-send-email-dsa-qUQiAmfTcIp+XZJcv9eMoEEOCMrvLtNR@public.gmane.org>
2016-10-17 12:21 ` Stephen Hemminger
2016-10-17 14:42 ` David Miller [this message]
2016-10-18 0:42 ` David Ahern
2016-10-15 1:28 ` [PATCH net-next 03/11] net: bonding: Flip to the new dev walk API David Ahern
2016-10-15 1:28 ` [PATCH net-next 05/11] IB/ipoib: Flip to " David Ahern
2016-10-15 1:28 ` [PATCH net-next 06/11] ixgbe: Flip to the " David Ahern
2016-10-15 1:28 ` [PATCH net-next 07/11] mlxsw: " David Ahern
2016-10-15 1:28 ` [PATCH net-next 10/11] net: Add warning if any lower device is still in adjacency list David Ahern
2016-10-15 1:28 ` [PATCH net-next 11/11] net: dev: Improve debug statements for adjacency tracking David Ahern
-- strict thread matches above, loose matches on Subject: below --
2016-10-18 2:15 [PATCH v3 net-next 00/11] net: Fix netdev " David Ahern
2016-10-18 2:15 ` [PATCH net-next 02/11] net: Introduce new api for walking upper and lower devices David Ahern
2016-10-12 20:51 [PATCH net-next 00/11] net: Fix netdev adjacency tracking David Ahern
2016-10-12 20:51 ` [PATCH net-next 02/11] net: Introduce new api for walking upper and lower devices David Ahern
2016-10-13 7:30 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161017.104200.2266025643403507437.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andy@greyhouse.net \
--cc=dledford@redhat.com \
--cc=dsa@cumulusnetworks.com \
--cc=hal.rosenstock@gmail.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=j.vosburgh@gmail.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jiri@mellanox.com \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sean.hefty@intel.com \
--cc=stephen@networkplumber.org \
--cc=vfalico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).