From: David Miller <davem@davemloft.net>
To: niklas.cassel@axis.com
Cc: larper@axis.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, niklass@axis.com
Subject: Re: [PATCH 1/2] dwc_eth_qos: do not clear pause flags from phy_device->supported
Date: Mon, 17 Oct 2016 12:53:53 -0400 (EDT) [thread overview]
Message-ID: <20161017.125353.119289785321107013.davem@davemloft.net> (raw)
In-Reply-To: <1476685548-15574-1-git-send-email-niklass@axis.com>
From: Niklas Cassel <niklas.cassel@axis.com>
Date: Mon, 17 Oct 2016 08:25:48 +0200
> From: Niklas Cassel <niklas.cassel@axis.com>
>
> phy_device->supported is originally set by the PHY driver.
> The ethernet driver should filter phy_device->supported to only contain
> flags supported by the IP.
> The IP supports setting rx and tx flow control independently,
> therefore SUPPORTED_Pause and SUPPORTED_Asym_Pause should not be cleared.
> If the flags are cleared, pause frames cannot be enabled (even if they
> are supported by the PHY).
>
> Signed-off-by: Niklas Cassel <niklas.cassel@axis.com>
> Signed-off-by: Lars Persson <larper@axis.com>
These two patches do not apply to the current 'net' tree, please respin.
prev parent reply other threads:[~2016-10-17 16:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-17 6:25 [PATCH 1/2] dwc_eth_qos: do not clear pause flags from phy_device->supported Niklas Cassel
2016-10-17 16:53 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161017.125353.119289785321107013.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=larper@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=niklas.cassel@axis.com \
--cc=niklass@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).