From: David Miller <davem@davemloft.net>
To: ivecera@redhat.com
Cc: netdev@vger.kernel.org, sony.chacko@qlogic.com,
Dept-HSGLinuxNICDev@qlogic.com
Subject: Re: [PATCH net] bnx2: fix locking when netconsole is used
Date: Mon, 17 Oct 2016 13:21:42 -0400 (EDT) [thread overview]
Message-ID: <20161017.132142.526817621160813690.davem@davemloft.net> (raw)
In-Reply-To: <1476721231-31624-1-git-send-email-ivecera@redhat.com>
From: Ivan Vecera <ivecera@redhat.com>
Date: Mon, 17 Oct 2016 18:20:31 +0200
> diff --git a/drivers/net/ethernet/broadcom/bnx2.c b/drivers/net/ethernet/broadcom/bnx2.c
> index 27f11a5..9c408413 100644
> --- a/drivers/net/ethernet/broadcom/bnx2.c
> +++ b/drivers/net/ethernet/broadcom/bnx2.c
> @@ -272,21 +272,24 @@ static u32
> bnx2_reg_rd_ind(struct bnx2 *bp, u32 offset)
> {
> u32 val;
> + unsigned long flags;
>
Please order local variable declarations from longest to shortest
line.
Thank you.
next prev parent reply other threads:[~2016-10-17 17:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-17 16:20 [PATCH net] bnx2: fix locking when netconsole is used Ivan Vecera
2016-10-17 17:21 ` David Miller [this message]
2016-10-18 6:16 ` Ivan Vecera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161017.132142.526817621160813690.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Dept-HSGLinuxNICDev@qlogic.com \
--cc=ivecera@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=sony.chacko@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).