* [PATCH] qed: Use list_move_tail instead of list_del/list_add_tail
@ 2016-10-17 15:17 Wei Yongjun
2016-10-17 19:10 ` Mintz, Yuval
0 siblings, 1 reply; 3+ messages in thread
From: Wei Yongjun @ 2016-10-17 15:17 UTC (permalink / raw)
To: Yuval Mintz, Ariel Elior; +Cc: Wei Yongjun, everest-linux-l2, netdev
From: Wei Yongjun <weiyongjun1@huawei.com>
Using list_move_tail() instead of list_del() + list_add_tail().
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/net/ethernet/qlogic/qed/qed_ll2.c | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/net/ethernet/qlogic/qed/qed_ll2.c b/drivers/net/ethernet/qlogic/qed/qed_ll2.c
index a6db107..a249c1d 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_ll2.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_ll2.c
@@ -537,8 +537,7 @@ void qed_ll2_rxq_flush(struct qed_hwfn *p_hwfn, u8 connection_handle)
if (!p_pkt)
break;
- list_del(&p_pkt->list_entry);
- list_add_tail(&p_pkt->list_entry, &p_rx->free_descq);
+ list_move_tail(&p_pkt->list_entry, &p_rx->free_descq);
rx_buf_addr = p_pkt->rx_buf_addr;
cookie = p_pkt->cookie;
@@ -992,9 +991,8 @@ static void qed_ll2_post_rx_buffer_notify_fw(struct qed_hwfn *p_hwfn,
p_posting_packet = list_first_entry(&p_rx->posting_descq,
struct qed_ll2_rx_packet,
list_entry);
- list_del(&p_posting_packet->list_entry);
- list_add_tail(&p_posting_packet->list_entry,
- &p_rx->active_descq);
+ list_move_tail(&p_posting_packet->list_entry,
+ &p_rx->active_descq);
b_notify_fw = true;
}
@@ -1188,8 +1186,7 @@ static void qed_ll2_tx_packet_notify(struct qed_hwfn *p_hwfn,
if (!p_pkt)
break;
- list_del(&p_pkt->list_entry);
- list_add_tail(&p_pkt->list_entry, &p_tx->active_descq);
+ list_move_tail(&p_pkt->list_entry, &p_tx->active_descq);
}
SET_FIELD(db_msg.params, CORE_DB_DATA_DEST, DB_DEST_XCM);
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] qed: Use list_move_tail instead of list_del/list_add_tail
2016-10-17 15:17 [PATCH] qed: Use list_move_tail instead of list_del/list_add_tail Wei Yongjun
@ 2016-10-17 19:10 ` Mintz, Yuval
2016-10-17 19:36 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Mintz, Yuval @ 2016-10-17 19:10 UTC (permalink / raw)
To: Wei Yongjun, Yuval Mintz, Ariel Elior
Cc: Wei Yongjun, everest-linux-l2@qlogic.com, netdev@vger.kernel.org
> Using list_move_tail() instead of list_del() + list_add_tail().
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Thanks.
Acked-by: Yuval Mintz <Yuval.Mintz@cavium.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] qed: Use list_move_tail instead of list_del/list_add_tail
2016-10-17 19:10 ` Mintz, Yuval
@ 2016-10-17 19:36 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2016-10-17 19:36 UTC (permalink / raw)
To: Yuval.Mintz
Cc: weiyj.lk, Yuval.Mintz, Ariel.Elior, weiyongjun1, everest-linux-l2,
netdev
From: "Mintz, Yuval" <Yuval.Mintz@cavium.com>
Date: Mon, 17 Oct 2016 19:10:10 +0000
>> Using list_move_tail() instead of list_del() + list_add_tail().
>
>> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
>
> Thanks.
> Acked-by: Yuval Mintz <Yuval.Mintz@cavium.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-10-17 19:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-17 15:17 [PATCH] qed: Use list_move_tail instead of list_del/list_add_tail Wei Yongjun
2016-10-17 19:10 ` Mintz, Yuval
2016-10-17 19:36 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).