From: David Miller <davem@davemloft.net>
To: tom@herbertland.com
Cc: netdev@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH v3 net-next 0/7] udp: Flow dissection for tunnels
Date: Tue, 18 Oct 2016 14:03:15 -0400 (EDT) [thread overview]
Message-ID: <20161018.140315.1520738555319027922.davem@davemloft.net> (raw)
In-Reply-To: <20161018170243.1369807-1-tom@herbertland.com>
From: Tom Herbert <tom@herbertland.com>
Date: Tue, 18 Oct 2016 10:02:36 -0700
> v3:
> - Fix build issues with modules that call IPv6 functions and
> CONFIG_INET is not set.
> - Fix compilation error in init'ing .flow_dissect in IPv6 UDP
> offload.
Still doesn't build:
net/ipv6/udp_offload.c:208:19: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
.flow_dissect = udp6_flow_dissect,
^
net/ipv6/udp_offload.c:208:19: note: (near initialization for ‘udpv6_offload.callbacks.flow_dissect’)
cc1: some warnings being treated as errors
scripts/Makefile.build:289: recipe for target 'net/ipv6/udp_offload.o' failed
make[2]: *** [net/ipv6/udp_offload.o] Error 1
make[2]: *** Waiting for unfinished jobs....
scripts/Makefile.build:440: recipe for target 'net/ipv6' failed
make[1]: *** [net/ipv6] Error 2
make[1]: *** Waiting for unfinished jobs....
Makefile:969: recipe for target 'net' failed
make: *** [net] Error 2
make: *** Waiting for unfinished jobs....
The final argument to udp6_flow_dissect() is marked const but that is not what the
method definition wants.
prev parent reply other threads:[~2016-10-18 18:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-18 17:02 [PATCH v3 net-next 0/7] udp: Flow dissection for tunnels Tom Herbert
2016-10-18 17:02 ` [PATCH v3 net-next 1/7] ipv6: Fix Makefile conditional to use CONFIG_INET Tom Herbert
2016-10-18 17:02 ` [PATCH v3 net-next 2/7] flow_dissector: Limit processing of next encaps and extensions Tom Herbert
2016-10-18 17:02 ` [PATCH v3 net-next 3/7] udp: Add socket lookup functions with noref Tom Herbert
2016-10-18 17:02 ` [PATCH v3 net-next 4/7] udp: UDP flow dissector Tom Herbert
2016-10-18 17:02 ` [PATCH v3 net-next 5/7] udp: Add UDP flow dissection functions to IPv4 and IPv6 Tom Herbert
2016-10-18 17:02 ` [PATCH v3 net-next 6/7] udp: UDP tunnel flow dissection infrastructure Tom Herbert
2016-10-18 17:02 ` [PATCH v3 net-next 7/7] fou: Support flow dissection Tom Herbert
2016-10-18 18:03 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161018.140315.1520738555319027922.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).