From: David Miller <davem@davemloft.net>
To: jbohac@suse.cz
Cc: julia.lawall@lip6.fr, kuznet@ms2.inr.ac.ru, jmorris@namei.org,
yoshfuji@linux-ipv6.org, kaber@trash.net, netdev@vger.kernel.org,
kbuild-all@01.org
Subject: Re: [PATCH] ipv6: fix signedness of tmp_prefered_lft underflow check
Date: Tue, 18 Oct 2016 14:25:25 -0400 (EDT) [thread overview]
Message-ID: <20161018.142525.1262217492229127435.davem@davemloft.net> (raw)
In-Reply-To: <20161018150154.4tpivtvxygp7kjpd@dwarf.suse.cz>
From: Jiri Bohac <jbohac@suse.cz>
Date: Tue, 18 Oct 2016 17:01:54 +0200
> Commit 76506a986dc31394fd1f2741db037d29c7e57843 (IPv6: fix
> DESYNC_FACTOR) introduced a buggy check for underflow of
> tmp_prefered_lft. tmp_prefered_lft is unsigned, so the condition
> is always false.
>
> Signed-off-by: Jiri Bohac <jbohac@suse.cz>
> Reported-by: Julia Lawall <julia.lawall@lip6.fr>
> Fixes: 76506a986dc3 ("IPv6: fix DESYNC_FACTOR")
Does the check make any sense at all? I'd say just remove it.
next prev parent reply other threads:[~2016-10-18 18:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-15 17:46 [net:master 10/15] net/ipv6/addrconf.c:1251:14-30: WARNING: Unsigned expression compared with zero: tmp_prefered_lft < 0 Julia Lawall
2016-10-18 15:01 ` [PATCH] ipv6: fix signedness of tmp_prefered_lft underflow check Jiri Bohac
2016-10-18 18:25 ` David Miller [this message]
2016-10-19 13:16 ` Jiri Bohac
2016-10-19 13:25 ` [PATCH] ipv6: don't check for tmp_prefered_lft underflow Jiri Bohac
2016-10-19 18:58 ` [PATCH] ipv6: fix signedness of tmp_prefered_lft underflow check David Miller
2016-10-20 10:29 ` [PATCH] ipv6: properly prevent temp_prefered_lft sysctl race Jiri Bohac
2016-10-20 18:29 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161018.142525.1262217492229127435.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jbohac@suse.cz \
--cc=jmorris@namei.org \
--cc=julia.lawall@lip6.fr \
--cc=kaber@trash.net \
--cc=kbuild-all@01.org \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).