From: David Miller <davem@davemloft.net>
To: stefan.wahren@i2se.com
Cc: gregkh@linuxfoundation.org, jslaby@suse.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 net-next 3/8] net: qualcomm: move qcaspi_tx_cmd to qca_spi.c
Date: Tue, 18 Oct 2016 14:28:13 -0400 (EDT) [thread overview]
Message-ID: <20161018.142813.519636152972010259.davem@davemloft.net> (raw)
In-Reply-To: <1476790054-27174-4-git-send-email-stefan.wahren@i2se.com>
From: Stefan Wahren <stefan.wahren@i2se.com>
Date: Tue, 18 Oct 2016 13:27:29 +0200
> diff --git a/drivers/net/ethernet/qualcomm/qca_7k.h b/drivers/net/ethernet/qualcomm/qca_7k.h
> index 1cad851..b390b1f 100644
> --- a/drivers/net/ethernet/qualcomm/qca_7k.h
> +++ b/drivers/net/ethernet/qualcomm/qca_7k.h
> @@ -67,6 +67,5 @@
> void qcaspi_spi_error(struct qcaspi *qca);
> int qcaspi_read_register(struct qcaspi *qca, u16 reg, u16 *result);
> int qcaspi_write_register(struct qcaspi *qca, u16 reg, u16 value);
> -int qcaspi_tx_cmd(struct qcaspi *qca, u16 cmd);
>
> #endif /* _QCA_7K_H */
> diff --git a/drivers/net/ethernet/qualcomm/qca_spi.c b/drivers/net/ethernet/qualcomm/qca_spi.c
> index 6e2add9..5bcac62 100644
> --- a/drivers/net/ethernet/qualcomm/qca_spi.c
> +++ b/drivers/net/ethernet/qualcomm/qca_spi.c
> @@ -192,6 +192,30 @@ qcaspi_read_legacy(struct qcaspi *qca, u8 *dst, u32 len)
> return len;
> }
>
> +int
> +qcaspi_tx_cmd(struct qcaspi *qca, u16 cmd)
> +{
If you do this then you must mark this function 'static'.
next prev parent reply other threads:[~2016-10-18 18:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-18 11:27 [PATCH v3 net-next 0/8] net: qualcomm: add QCA7000 UART driver Stefan Wahren
2016-10-18 11:27 ` [PATCH v3 net-next 1/8] net: qualcomm: remove unnecessary includes Stefan Wahren
2016-10-18 11:27 ` [PATCH v3 net-next 2/8] net: qca_debug: use net_device_ops instead of direct call Stefan Wahren
2016-10-18 11:27 ` [PATCH v3 net-next 3/8] net: qualcomm: move qcaspi_tx_cmd to qca_spi.c Stefan Wahren
2016-10-18 18:28 ` David Miller [this message]
2016-10-18 11:27 ` [PATCH v3 net-next 4/8] net: qualcomm: rename qca_framing.c to qca_common.c Stefan Wahren
2016-10-18 11:40 ` Greg Kroah-Hartman
2016-10-18 11:27 ` [PATCH v3 net-next 5/8] net: qualcomm: move MTU handling to qca_common Stefan Wahren
2016-10-18 18:29 ` David Miller
2016-10-18 11:27 ` [PATCH v3 net-next 6/8] net: qualcomm: prepare frame decoding for UART driver Stefan Wahren
2016-10-18 11:27 ` [PATCH v3 net-next 7/8] net: qualcomm: make qca_common a separate kernel module Stefan Wahren
2016-10-18 11:27 ` [PATCH v3 net-next 8/8] net: qualcomm: add QCA7000 UART driver Stefan Wahren
2016-10-18 18:30 ` David Miller
2016-10-21 11:38 ` Stefan Wahren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161018.142813.519636152972010259.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).