* [PATCH -next] net: dsa: mv88e6xxx: fix non static symbol warning
@ 2016-10-18 15:53 Wei Yongjun
2016-10-18 15:56 ` Andrew Lunn
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2016-10-18 15:53 UTC (permalink / raw)
To: Andrew Lunn, Vivien Didelot, Florian Fainelli; +Cc: Wei Yongjun, netdev
From: Wei Yongjun <weiyongjun1@huawei.com>
Fixes the following sparse warning:
drivers/net/dsa/mv88e6xxx/chip.c:2866:5: warning:
symbol 'mv88e6xxx_g1_set_switch_mac' was not declared. Should it be static?
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/net/dsa/mv88e6xxx/chip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c
index ac03297..157360f 100644
--- a/drivers/net/dsa/mv88e6xxx/chip.c
+++ b/drivers/net/dsa/mv88e6xxx/chip.c
@@ -2863,7 +2863,7 @@ static int mv88e6xxx_setup_port(struct mv88e6xxx_chip *chip, int port)
return mv88e6xxx_port_write(chip, port, PORT_DEFAULT_VLAN, 0x0000);
}
-int mv88e6xxx_g1_set_switch_mac(struct mv88e6xxx_chip *chip, u8 *addr)
+static int mv88e6xxx_g1_set_switch_mac(struct mv88e6xxx_chip *chip, u8 *addr)
{
int err;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] net: dsa: mv88e6xxx: fix non static symbol warning
2016-10-18 15:53 [PATCH -next] net: dsa: mv88e6xxx: fix non static symbol warning Wei Yongjun
@ 2016-10-18 15:56 ` Andrew Lunn
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Lunn @ 2016-10-18 15:56 UTC (permalink / raw)
To: Wei Yongjun; +Cc: Vivien Didelot, Florian Fainelli, Wei Yongjun, netdev
On Tue, Oct 18, 2016 at 03:53:37PM +0000, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Fixes the following sparse warning:
>
> drivers/net/dsa/mv88e6xxx/chip.c:2866:5: warning:
> symbol 'mv88e6xxx_g1_set_switch_mac' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-10-18 15:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-18 15:53 [PATCH -next] net: dsa: mv88e6xxx: fix non static symbol warning Wei Yongjun
2016-10-18 15:56 ` Andrew Lunn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).