From: David Miller <davem@davemloft.net>
To: robert.jarzmik@free.fr
Cc: nico@fluxnic.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: smc91x: fix neponset breakage by pxa u16 writes
Date: Thu, 20 Oct 2016 11:21:12 -0400 (EDT) [thread overview]
Message-ID: <20161020.112112.836590043273464129.davem@davemloft.net> (raw)
In-Reply-To: <1476912230-18175-1-git-send-email-robert.jarzmik@free.fr>
From: Robert Jarzmik <robert.jarzmik@free.fr>
Date: Wed, 19 Oct 2016 23:23:50 +0200
> The patch isolating the u16 writes for pxa assumed all machine_is_*()
> calls were removed, and therefore removed the mach-types.h include which
> provided them.
>
> Unfortunately 2 machine_is_*() remained in smc91x.c file including
> smc91x.h from which the include was removed, triggering the error:
> drivers/net/ethernet/smsc/smc91x.c: In function ‘smc_drv_probe’:
> drivers/net/ethernet/smsc/smc91x.c:2380:2: error: implicit declaration
> of function ‘machine_is_assabet’
> [-Werror=implicit-function-declaration]
> if (machine_is_assabet() && machine_has_neponset())
>
> This adds back the wrongly removed include.
>
> Fixes: d09d747ae4c2 ("net: smc91x: isolate u16 writes alignment workaround")
> Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
Applied.
prev parent reply other threads:[~2016-10-20 15:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-19 21:23 [PATCH] net: smc91x: fix neponset breakage by pxa u16 writes Robert Jarzmik
2016-10-20 15:21 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161020.112112.836590043273464129.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nico@fluxnic.net \
--cc=robert.jarzmik@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).