From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] tcp: relax listening_hash operations
Date: Thu, 20 Oct 2016 11:24:59 -0400 (EDT) [thread overview]
Message-ID: <20161020.112459.564839965287134365.davem@davemloft.net> (raw)
In-Reply-To: <1476937498.5650.102.camel@edumazet-glaptop3.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 19 Oct 2016 21:24:58 -0700
> From: Eric Dumazet <edumazet@google.com>
>
> softirq handlers use RCU protection to lookup listeners,
> and write operations all happen from process context.
> We do not need to block BH for dump operations.
>
> Also SYN_RECV since request sockets are stored in the ehash table :
>
> 1) inet_diag_dump_icsk() no longer need to clear
> cb->args[3] and cb->args[4] that were used as cursors while
> iterating the old per listener hash table.
>
> 2) Also factorize a test : No need to scan listening_hash[]
> if r->id.idiag_dport is not zero.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied, thanks Eric.
prev parent reply other threads:[~2016-10-20 15:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-20 4:24 [PATCH net-next] tcp: relax listening_hash operations Eric Dumazet
2016-10-20 15:24 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161020.112459.564839965287134365.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).