* [PATCH (net.git)] stmmac: display the descriptors if DES0 = 0
@ 2016-10-20 8:01 Giuseppe Cavallaro
2016-10-20 9:29 ` Alexandre Torgue
2016-10-20 15:27 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Giuseppe Cavallaro @ 2016-10-20 8:01 UTC (permalink / raw)
To: netdev; +Cc: Giuseppe Cavallaro, Alexandre TORGUE
It makes sense to display the descriptors even if
DES0 is zero. This helps for example in case of it
is needed to dump rx write-back descriptors to get
timestamp status.
Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>
Cc: Alexandre TORGUE <alexandre.torgue@st.com>
---
drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c b/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c
index 4ec7397..a1b17cd 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c
@@ -347,10 +347,9 @@ static void dwmac4_display_ring(void *head, unsigned int size, bool rx)
pr_info("%s descriptor ring:\n", rx ? "RX" : "TX");
for (i = 0; i < size; i++) {
- if (p->des0)
- pr_info("%d [0x%x]: 0x%x 0x%x 0x%x 0x%x\n",
- i, (unsigned int)virt_to_phys(p),
- p->des0, p->des1, p->des2, p->des3);
+ pr_info("%d [0x%x]: 0x%x 0x%x 0x%x 0x%x\n",
+ i, (unsigned int)virt_to_phys(p),
+ p->des0, p->des1, p->des2, p->des3);
p++;
}
}
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH (net.git)] stmmac: display the descriptors if DES0 = 0
2016-10-20 8:01 [PATCH (net.git)] stmmac: display the descriptors if DES0 = 0 Giuseppe Cavallaro
@ 2016-10-20 9:29 ` Alexandre Torgue
2016-10-20 15:27 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Alexandre Torgue @ 2016-10-20 9:29 UTC (permalink / raw)
To: Giuseppe Cavallaro, netdev
Hi Peppe,
On 10/20/2016 10:01 AM, Giuseppe Cavallaro wrote:
> It makes sense to display the descriptors even if
> DES0 is zero. This helps for example in case of it
> is needed to dump rx write-back descriptors to get
> timestamp status.
>
> Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>
> Cc: Alexandre TORGUE <alexandre.torgue@st.com>
> ---
> drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c b/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c
> index 4ec7397..a1b17cd 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c
> @@ -347,10 +347,9 @@ static void dwmac4_display_ring(void *head, unsigned int size, bool rx)
> pr_info("%s descriptor ring:\n", rx ? "RX" : "TX");
>
> for (i = 0; i < size; i++) {
> - if (p->des0)
> - pr_info("%d [0x%x]: 0x%x 0x%x 0x%x 0x%x\n",
> - i, (unsigned int)virt_to_phys(p),
> - p->des0, p->des1, p->des2, p->des3);
> + pr_info("%d [0x%x]: 0x%x 0x%x 0x%x 0x%x\n",
> + i, (unsigned int)virt_to_phys(p),
> + p->des0, p->des1, p->des2, p->des3);
> p++;
> }
> }
>
I agree. Acked-by: Alexandre Torgue <alexandre.torgue@st.com>
Thanks
Alex
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH (net.git)] stmmac: display the descriptors if DES0 = 0
2016-10-20 8:01 [PATCH (net.git)] stmmac: display the descriptors if DES0 = 0 Giuseppe Cavallaro
2016-10-20 9:29 ` Alexandre Torgue
@ 2016-10-20 15:27 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2016-10-20 15:27 UTC (permalink / raw)
To: peppe.cavallaro; +Cc: netdev, alexandre.torgue
From: Giuseppe Cavallaro <peppe.cavallaro@st.com>
Date: Thu, 20 Oct 2016 10:01:28 +0200
> It makes sense to display the descriptors even if
> DES0 is zero. This helps for example in case of it
> is needed to dump rx write-back descriptors to get
> timestamp status.
>
> Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-10-20 15:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-20 8:01 [PATCH (net.git)] stmmac: display the descriptors if DES0 = 0 Giuseppe Cavallaro
2016-10-20 9:29 ` Alexandre Torgue
2016-10-20 15:27 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).