From: David Miller <davem@davemloft.net>
To: Raghu.Vatsavayi@cavium.com
Cc: netdev@vger.kernel.org, Derek.Chickles@cavium.com,
Satananda.Burla@cavium.com, Felix.Manlunas@cavium.com
Subject: Re: [PATCH net-next V2 1/9] liquidio CN23XX: HW config for VF support
Date: Thu, 20 Oct 2016 16:57:20 -0400 (EDT) [thread overview]
Message-ID: <20161020.165720.1537348879596195765.davem@davemloft.net> (raw)
In-Reply-To: <DM3PR07MB21387F2B6D44558DBC36649881D50@DM3PR07MB2138.namprd07.prod.outlook.com>
From: "Vatsavayi, Raghu" <Raghu.Vatsavayi@cavium.com>
Date: Thu, 20 Oct 2016 20:01:37 +0000
>
>
>> -----Original Message-----
>> From: David Miller [mailto:davem@davemloft.net]
>> Sent: Thursday, October 20, 2016 11:13 AM
>> To: Vatsavayi, Raghu
>> Cc: netdev@vger.kernel.org; Vatsavayi, Raghu; Chickles, Derek; Burla,
>> Satananda; Manlunas, Felix
>> Subject: Re: [PATCH net-next V2 1/9] liquidio CN23XX: HW config for VF
>> support
>>
>> From: Raghu Vatsavayi <rvatsavayi@caviumnetworks.com>
>> Date: Wed, 19 Oct 2016 22:40:38 -0700
>>
>> > +/* Default behaviour of Liquidio is to provide one queue per VF. But
>> > +Liquidio
>> > + * can also provide multiple queues to each VF. If user wants to
>> > +change the
>> > + * default behaviour HW should be provided configuration info at init
>> > +time,
>> > + * based on which it will create control queues for communicating with
>> FW.
>> > + */
>> > +static u32 max_vfs[2] = { 0, 0 };
>> > +module_param_array(max_vfs, int, NULL, 0444);
>> > +MODULE_PARM_DESC(max_vfs, "Assign two comma-separated unsigned
>> > +integers that specify max number of VFs for PF0 (left of the comma)
>> > +and PF1 (right of the comma); for 23xx only. By default HW will
>> > +configure as many VFs as queues after allocating PF queues.To
>> > +increase queues for VF use this parameter. Use sysfs to create these
>> > +VFs.");
>> > +
>> > +static unsigned int num_queues_per_pf[2] = { 0, 0 };
>> > +module_param_array(num_queues_per_pf, uint, NULL, 0444);
>> > +MODULE_PARM_DESC(num_queues_per_pf, "two comma-separated
>> unsigned
>> > +integers that specify number of queues per PF0 (left of the comma)
>> > +and PF1 (right of the comma); for 23xx only");
>> > +
>> > static int ptp_enable = 1;
>>
>> We cannot continue to allow drivers to add custom module parameters to
>> control this. It is the worst user experience possible.
>>
>> We need a tree-wide generic, consistent, manner in which to configure and
>> control this kind of thing.
>
> Sure Dave, I will remove max_vfs module parameter and will use tree wide generic
> sysfs interface to enable VFs.
That's not what I meant.
I mean there needs to be a generic mechanism that isn't a per-device
knob (be it a module parameter or a sysctl, to me these are identical
functionality and user experience wise).
Something like ethtool or netlink.
next prev parent reply other threads:[~2016-10-20 20:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-20 5:40 [PATCH net-next V2 0/9] liquidio CN23XX VF support Raghu Vatsavayi
2016-10-20 5:40 ` [PATCH net-next V2 1/9] liquidio CN23XX: HW config for " Raghu Vatsavayi
2016-10-20 18:13 ` David Miller
2016-10-20 20:01 ` Vatsavayi, Raghu
2016-10-20 20:57 ` David Miller [this message]
2016-10-20 21:15 ` Vatsavayi, Raghu
2016-10-20 23:08 ` Vatsavayi, Raghu
2016-10-20 5:40 ` [PATCH net-next V2 2/9] liquidio CN23XX: sysfs VF config support Raghu Vatsavayi
2016-10-20 5:40 ` [PATCH net-next V2 3/9] liquidio CN23XX: Mailbox support Raghu Vatsavayi
2016-10-20 5:40 ` [PATCH net-next V2 4/9] liquidio CN23XX: mailbox interrupt processing Raghu Vatsavayi
2016-10-20 5:40 ` [PATCH net-next V2 5/9] liquidio CN23XX: VF related operations Raghu Vatsavayi
2016-10-20 5:40 ` [PATCH net-next V2 6/9] liquidio CN23XX: device states Raghu Vatsavayi
2016-10-20 5:40 ` [PATCH net-next V2 7/9] liquidio CN23XX: code cleanup Raghu Vatsavayi
2016-10-20 5:40 ` [PATCH net-next V2 8/9] liquidio CN23XX: copyrights changes and alignment Raghu Vatsavayi
2016-10-20 5:40 ` [PATCH net-next V2 9/9] liquidio CN23XX: fix for new check patch errors Raghu Vatsavayi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161020.165720.1537348879596195765.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Derek.Chickles@cavium.com \
--cc=Felix.Manlunas@cavium.com \
--cc=Raghu.Vatsavayi@cavium.com \
--cc=Satananda.Burla@cavium.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).