From: Tony Lindgren <tony@atomide.com>
To: Jeroen Hofstee <jhofstee@victronenergy.com>
Cc: netdev@vger.kernel.org, Mugunthan V N <mugunthanvnm@ti.com>,
Grygorii Strashko <grygorii.strashko@ti.com>,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: cpsw: fix obtaining mac address for am3517
Date: Thu, 20 Oct 2016 23:38:52 -0700 [thread overview]
Message-ID: <20161021063851.6frul6pemo52i7ot@atomide.com> (raw)
In-Reply-To: <1476993351-23065-1-git-send-email-jhofstee@victronenergy.com>
* Jeroen Hofstee <jhofstee@victronenergy.com> [161020 12:57]:
> Commit b6745f6e4e63 ("drivers: net: cpsw: davinci_emac: move reading mac
> id to common file") did not only move the code for an am3517, it also
> added the slave parameter, resulting in a invalid (all zero) mac address
> being returned. So change it back to always read from slave zero, so it
> works again.
Hmm doesn't this now break it for cpsw with two instances? We may need
am3517 specific quirk flag instead?
Regards,
Tony
next parent reply other threads:[~2016-10-21 6:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1476993351-23065-1-git-send-email-jhofstee@victronenergy.com>
2016-10-21 6:38 ` Tony Lindgren [this message]
2016-10-21 7:36 ` [PATCH] net: cpsw: fix obtaining mac address for am3517 Jeroen Hofstee
2016-10-21 7:53 ` Tony Lindgren
2016-10-21 9:30 ` Jeroen Hofstee
2016-10-21 9:51 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161021063851.6frul6pemo52i7ot@atomide.com \
--to=tony@atomide.com \
--cc=grygorii.strashko@ti.com \
--cc=jhofstee@victronenergy.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).