netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: jann@thejh.net
Cc: pablo@netfilter.org, kuznet@ms2.inr.ac.ru, jmorris@namei.org,
	yoshfuji@linux-ipv6.org, netdev@vger.kernel.org,
	netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] netfilter: don't permit unprivileged writes to global state via sysctls
Date: Sat, 22 Oct 2016 18:43:16 -0400 (EDT)	[thread overview]
Message-ID: <20161022.184316.791487930434404648.davem@davemloft.net> (raw)
In-Reply-To: <20161022212342.GD3334@pc.thejh.net>

From: Jann Horn <jann@thejh.net>
Date: Sat, 22 Oct 2016 23:23:42 +0200

> On Thu, Oct 20, 2016 at 02:37:47PM -0400, David Miller wrote:
>> From: Pablo Neira Ayuso <pablo@netfilter.org>
>> Date: Thu, 20 Oct 2016 20:22:24 +0200
>> 
>> > On Sat, Sep 24, 2016 at 12:21:04AM +0200, Jann Horn wrote:
>> >> This prevents the modification of nf_conntrack_max in unprivileged network
>> >> namespaces. For unprivileged network namespaces, ip_conntrack_max is kept
>> >> as a readonly sysctl in order to minimize potential compatibility issues.
>> >> 
>> >> This patch should apply cleanly to the net tree.
>> > 
>> > For the record: This patch looks good to me, but this legacy
>> > ip_conntrack sysctl code is now gone.
>> > 
>> > I don't know what is the procedure to get this to -stable branches now
>> > that this cannot be pushed upstream.
>> 
>> In the commit message for the -stable submission simply say "Not
>> applicable" in the upstream commit reference.  Like:
>> 
>> 	[ Upstream commit: Not applicable ]
>> 
>> or something like that.
> 
> Who should do that? Me, after getting a maintainer ack? Or the maintainer?

When the maintainer submits a patch to -stable, that's what they
add to the commit message.

      reply	other threads:[~2016-10-22 22:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-23 22:21 [PATCH] netfilter: don't permit unprivileged writes to global state via sysctls Jann Horn
2016-10-20 18:22 ` Pablo Neira Ayuso
2016-10-20 18:37   ` David Miller
2016-10-22 21:23     ` Jann Horn
2016-10-22 22:43       ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161022.184316.791487930434404648.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=jann@thejh.net \
    --cc=jmorris@namei.org \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).