From: David Miller <davem@davemloft.net>
To: fgao@ikuai8.com
Cc: jasowang@redhat.com, edumazet@google.com, pabeni@redhat.com,
netdev@vger.kernel.org, gfree.wind@gmail.com
Subject: Re: [PATCH v2 net-next 1/1] driver: tun: Forbid to set IFF_TUN and IFF_TAP at the same time
Date: Sun, 23 Oct 2016 17:40:43 -0400 (EDT) [thread overview]
Message-ID: <20161023.174043.122548847583183053.davem@davemloft.net> (raw)
In-Reply-To: <1477047735-26003-1-git-send-email-fgao@ikuai8.com>
From: fgao@ikuai8.com
Date: Fri, 21 Oct 2016 19:02:15 +0800
> From: Gao Feng <fgao@ikuai8.com>
>
> Current tun driver permits the ifr_flags is set with IFF_TUN and
> IFF_TAP at the same time. But actually there is only IFF_TUN flag
> works. And it does not make sense these two flags are set, so add
> this check.
>
> Signed-off-by: Gao Feng <fgao@ikuai8.com>
We've allowed this for too long to start failing on it now, sorry.
prev parent reply other threads:[~2016-10-23 21:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-21 11:02 [PATCH v2 net-next 1/1] driver: tun: Forbid to set IFF_TUN and IFF_TAP at the same time fgao
2016-10-21 11:28 ` Eric Dumazet
2016-10-21 11:32 ` Gao Feng
2016-10-23 21:40 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161023.174043.122548847583183053.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fgao@ikuai8.com \
--cc=gfree.wind@gmail.com \
--cc=jasowang@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox