From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next RFC WIP] Patch for XDP support for virtio_net Date: Wed, 26 Oct 2016 12:52:45 -0400 (EDT) Message-ID: <20161026.125245.1630138589657247338.davem@davemloft.net> References: <1477109243-29520-1-git-send-email-shrijeet@gmail.com> <20161026155202.5d99d935@redhat.com> <20161026185743-mutt-send-email-mst@kernel.org> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: brouer@redhat.com, shrijeet@gmail.com, tom@herbertland.com, netdev@vger.kernel.org, shm@cumulusnetworks.com, roopa@cumulusnetworks.com, nikolay@cumulusnetworks.com To: mst@redhat.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:37582 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752432AbcJZQwt (ORCPT ); Wed, 26 Oct 2016 12:52:49 -0400 In-Reply-To: <20161026185743-mutt-send-email-mst@kernel.org> Sender: netdev-owner@vger.kernel.org List-ID: From: "Michael S. Tsirkin" Date: Wed, 26 Oct 2016 19:36:45 +0300 > On Wed, Oct 26, 2016 at 03:52:02PM +0200, Jesper Dangaard Brouer wrote: >> On Sat, 22 Oct 2016 04:07:23 +0000 >> Shrijeet Mukherjee wrote: >> >> > This patch adds support for xdp ndo and also inserts the xdp program >> > call into the merged RX buffers and big buffers paths >> >> I really appreciate you are doing this for virtio_net. >> >> My first question is: Is the (packet) page data writable? >> (MST might be able to answer?) >> >> As this is currently an XDP requirement[1]. > > I'm not sure I understand what does writable mean. > Could you explain a bit more pls? > We do copy data into skb ATM but I plan to change that. The packet data area must be writable, and the page it lives in must not be shared with any other entity in the system. This is because the eBPF program that executes via XDP must be able to modify and read arbitrary parts of the packet area.