From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org, jikos@kernel.org, jhs@mojatatu.com
Subject: Re: [PATCH net-next] sch_htb: do not report fake rate estimators
Date: Wed, 26 Oct 2016 17:14:40 -0400 (EDT) [thread overview]
Message-ID: <20161026.171440.638427532009685965.davem@davemloft.net> (raw)
In-Reply-To: <1477065763.7065.84.camel@edumazet-glaptop3.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 21 Oct 2016 09:02:43 -0700
> From: Eric Dumazet <edumazet@google.com>
>
> When I prepared commit d250a5f90e53 ("pkt_sched: gen_estimator: Dont
> report fake rate estimators"), htb still had an implicit rate estimator
> for all its classes.
>
> Then later, I made this rate estimator optional in commit 64153ce0a7b6
> ("net_sched: htb: do not setup default rate estimators"), but I forgot
> to update htb use of gnet_stats_copy_rate_est()
>
> After this patch, "tc -s qdisc ..." no longer report fake rate
> estimators for HTB classes.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied, thanks Eric.
prev parent reply other threads:[~2016-10-26 21:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-21 16:02 [PATCH net-next] sch_htb: do not report fake rate estimators Eric Dumazet
2016-10-26 21:14 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161026.171440.638427532009685965.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=jhs@mojatatu.com \
--cc=jikos@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).