From: Stephen Hemminger <stephen@networkplumber.org>
To: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: netdev@vger.kernel.org, daniel@iogearbox.net,
xiyou.wangcong@gmail.com, mrv@mojatatu.com
Subject: Re: [PATCH iproute2 2/2] tc filters: fix filters to display handle when deleted even when no option
Date: Wed, 26 Oct 2016 10:57:49 -0700 [thread overview]
Message-ID: <20161026105749.1e366ef7@xeon-e3> (raw)
In-Reply-To: <1476696885-22214-2-git-send-email-jhs@emojatatu.com>
On Mon, 17 Oct 2016 05:34:45 -0400
Jamal Hadi Salim <jhs@mojatatu.com> wrote:
> From: Jamal Hadi Salim <jhs@mojatatu.com>
>
> Fix a few stylistic things that hurt my eyes while at it.
>
> Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com>
This patch has whitespace issues, please fix and resubmit.
ARNING: suspect code indent for conditional statements (16, 19)
#127: FILE: tc/f_fw.c:126:
+ if (tb[TCA_FW_MASK]) {
+ __u32 tmask = rta_getattr_u32(tb[TCA_FW_MASK]);
WARNING: Statements should start on a tabstop
#131: FILE: tc/f_fw.c:129:
+ if (tmask != 0xFFFFFFFF)
WARNING: suspect code indent for conditional statements (19, 27)
#131: FILE: tc/f_fw.c:129:
+ if (tmask != 0xFFFFFFFF)
+ mask = tmask;
prev parent reply other threads:[~2016-10-26 17:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-17 9:34 [PATCH iproute2 1/2] tc filters: display handle in events when a filter is deleted Jamal Hadi Salim
2016-10-17 9:34 ` [PATCH iproute2 2/2] tc filters: fix filters to display handle when deleted even when no option Jamal Hadi Salim
2016-10-26 17:57 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161026105749.1e366ef7@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=daniel@iogearbox.net \
--cc=jhs@mojatatu.com \
--cc=mrv@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).