netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: jkbs@redhat.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org,
	kaber@trash.net, edumazet@google.com
Subject: Re: [PATCH net-next 4/5] ipv6: Compute multipath hash for sent ICMP errors from offending packet
Date: Thu, 27 Oct 2016 11:24:13 -0400 (EDT)	[thread overview]
Message-ID: <20161027.112413.1616222035100737672.davem@davemloft.net> (raw)
In-Reply-To: <1477301332-23954-5-git-send-email-jkbs@redhat.com>

From: Jakub Sitnicki <jkbs@redhat.com>
Date: Mon, 24 Oct 2016 11:28:51 +0200

> diff --git a/include/linux/icmpv6.h b/include/linux/icmpv6.h
> index 57086e9..6282e03 100644
> --- a/include/linux/icmpv6.h
> +++ b/include/linux/icmpv6.h
> @@ -45,4 +45,6 @@ extern void				icmpv6_flow_init(struct sock *sk,
>  							 const struct in6_addr *saddr,
>  							 const struct in6_addr *daddr,
>  							 int oif);
> +struct ipv6hdr;
> +extern u32				icmpv6_multipath_hash(const struct ipv6hdr *iph);
>  #endif

We do not use "extern" in external function declarations in header file any more.

  parent reply	other threads:[~2016-10-27 15:24 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-24  9:28 [PATCH net-next 0/5] Route ICMPv6 errors with the flow when ECMP in use Jakub Sitnicki
2016-10-24  9:28 ` [PATCH net-next 1/5] ipv6: Fold rt6_info_hash_nhsfn() into its only caller Jakub Sitnicki
2016-10-24  9:28 ` [PATCH net-next 2/5] net: Extend struct flowi6 with multipath hash Jakub Sitnicki
2016-10-24  9:39   ` Hannes Frederic Sowa
2016-10-24  9:28 ` [PATCH net-next 3/5] ipv6: Use multipath hash from flow info if available Jakub Sitnicki
2016-10-24  9:40   ` Hannes Frederic Sowa
2016-10-24  9:28 ` [PATCH net-next 4/5] ipv6: Compute multipath hash for sent ICMP errors from offending packet Jakub Sitnicki
2016-10-24  9:40   ` Hannes Frederic Sowa
2016-10-27 15:24   ` David Miller [this message]
2016-10-27 22:00     ` Jakub Sitnicki
2016-10-24  9:28 ` [PATCH net-next 5/5] ipv6: Compute multipath hash for forwarded " Jakub Sitnicki
2016-10-24  9:43   ` Hannes Frederic Sowa
2016-10-27 15:25   ` David Miller
2016-10-27 22:10     ` Jakub Sitnicki
2016-10-27 22:35   ` Tom Herbert
2016-10-28  8:32     ` Jakub Sitnicki
2016-10-28 14:25       ` Tom Herbert
2016-10-30 13:03         ` Jakub Sitnicki
2016-10-31 19:15           ` David Miller
2016-11-01 15:13             ` Jakub Sitnicki
2016-11-01 15:35               ` David Miller
2016-11-01 16:26                 ` Jakub Sitnicki
2016-11-01 16:27                 ` Hannes Frederic Sowa
2016-11-01 16:39                   ` David Miller
2016-11-01 16:59                     ` Hannes Frederic Sowa
2016-10-31 19:25           ` Tom Herbert
2016-11-01 15:43             ` Jakub Sitnicki
2016-11-01 16:25             ` Hannes Frederic Sowa
2016-11-01 16:39               ` Tom Herbert
2016-11-01 16:54                 ` Hannes Frederic Sowa
2016-10-27 15:23 ` [PATCH net-next 0/5] Route ICMPv6 errors with the flow when ECMP in use David Miller
2016-10-27 21:54   ` Hannes Frederic Sowa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161027.112413.1616222035100737672.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=jkbs@redhat.com \
    --cc=jmorris@namei.org \
    --cc=kaber@trash.net \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).