From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: lorenzo@google.com, netdev@vger.kernel.org, ek@google.com,
zenczykowski@gmail.com
Subject: Re: [PATCH net-next 1/3] net: core: Add a UID field to struct sock.
Date: Thu, 27 Oct 2016 16:02:11 -0400 (EDT) [thread overview]
Message-ID: <20161027.160211.1148220212159032382.davem@davemloft.net> (raw)
In-Reply-To: <1477589786.7065.220.camel@edumazet-glaptop3.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 27 Oct 2016 10:36:26 -0700
> On Fri, 2016-10-28 at 02:20 +0900, Lorenzo Colitti wrote:
>
>> diff --git a/net/core/sock.c b/net/core/sock.c
>> index d8e4532e..831e4e8 100644
>> --- a/net/core/sock.c
>> +++ b/net/core/sock.c
>> @@ -1570,6 +1570,7 @@ struct sock *sk_clone_lock(const struct sock *sk, const gfp_t priority)
>> */
>> sk_refcnt_debug_inc(newsk);
>> sk_set_socket(newsk, NULL);
>> + newsk->sk_uid = sk->sk_uid;
>
> Not sure why this is needed ?
>
> sk_clone_lock() already copies sk to newsk, using sock_copy(newsk, sk);
Agreed.
next prev parent reply other threads:[~2016-10-27 20:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-27 17:20 [PATCH net-next] net: inet: Support UID-based routing Lorenzo Colitti
2016-10-27 17:20 ` [PATCH net-next 1/3] net: core: Add a UID field to struct sock Lorenzo Colitti
2016-10-27 17:36 ` Eric Dumazet
2016-10-27 20:02 ` David Miller [this message]
2016-10-27 19:05 ` kbuild test robot
2016-10-27 17:20 ` [PATCH net-next 2/3] net: core: add UID to flows, rules, and routes Lorenzo Colitti
2016-10-27 17:20 ` [PATCH net-next 3/3] net: inet: Support UID-based routing in IP protocols Lorenzo Colitti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161027.160211.1148220212159032382.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ek@google.com \
--cc=eric.dumazet@gmail.com \
--cc=lorenzo@google.com \
--cc=netdev@vger.kernel.org \
--cc=zenczykowski@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).