From: David Miller <davem@davemloft.net>
To: elicooper@gmx.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] ip6_tunnel: Clear IP6CB(skb)->frag_max_size in ip4ip6_tnl_xmit()
Date: Thu, 27 Oct 2016 16:25:14 -0400 (EDT) [thread overview]
Message-ID: <20161027.162514.2259363994362412217.davem@davemloft.net> (raw)
In-Reply-To: <20161024150712.5133-1-elicooper@gmx.com>
From: Eli Cooper <elicooper@gmx.com>
Date: Mon, 24 Oct 2016 23:07:12 +0800
> diff --git a/net/ipv6/ip6_tunnel.c b/net/ipv6/ip6_tunnel.c
> index 202d16a..4110562 100644
> --- a/net/ipv6/ip6_tunnel.c
> +++ b/net/ipv6/ip6_tunnel.c
> @@ -1205,6 +1205,7 @@ ip4ip6_tnl_xmit(struct sk_buff *skb, struct net_device *dev)
> int err;
>
> memset(&(IPCB(skb)->opt), 0, sizeof(IPCB(skb)->opt));
> + IP6CB(skb)->frag_max_size = 0;
>
> tproto = ACCESS_ONCE(t->parms.proto);
> if (tproto != IPPROTO_IPIP && tproto != 0)
This doesn't look right at all.
Either skb->cb is interpreted as IPCB() past this point, or
it is interpreted as IP6CB().
So pick which structure is used, and simply clear that specific
structure.
prev parent reply other threads:[~2016-10-27 20:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-24 15:07 [PATCH] ip6_tunnel: Clear IP6CB(skb)->frag_max_size in ip4ip6_tnl_xmit() Eli Cooper
2016-10-27 20:25 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161027.162514.2259363994362412217.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=elicooper@gmx.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).