From: Shmulik Ladkani <shmulik.ladkani@gmail.com>
To: Phil Sutter <phil@nwl.cc>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
Jamal Hadi Salim <jhs@mojatatu.com>,
netdev@vger.kernel.org
Subject: Re: [PATCHv2 iproute2 net-next] tc: m_mirred: Fix parsing of 'index' optional argument
Date: Thu, 27 Oct 2016 17:22:39 +0300 [thread overview]
Message-ID: <20161027172239.7bf5cc40@pixies> (raw)
In-Reply-To: <20161027094633.GR5640@orbyte.nwl.cc>
Hi Phil,
On Thu, 27 Oct 2016 11:46:33 +0200, phil@nwl.cc wrote:
> According to the action's help text (and the man page which is based
> upon that), this behaviour is perfectly fine:
>
> | Usage: mirred <DIRECTION> <ACTION> [index INDEX] <dev DEVICENAME>
>
> So first argument *must* be the direction, second one *must* be the
> action, then an optional index and the last one *must* be the interface.
There is an inconsistency betweem man/help and code.
Actual code, since first committed, attempts to parse "index" as 1st
argument (without success), see parse_mirred():
if (matches(*argv, "egress") == 0 || matches(*argv, "index") == 0) {
int ret = parse_egress(a, &argc, &argv, tca_id, n);
> While I don't see a problem with changing that (apart from that I don't
> think it's necessary)
Not "changing" per-se, but rather "fixing", at least according code
author's intention :)
As I suggested in the notes part of the commit log,
>> An alternative solution: banning "index" as 1st argument in parse_mirred
I ok with removing the code trying to support "index" as 1st argument as
well.
I only assumed one might want this behaviour due to intention expressed
by original code.
next prev parent reply other threads:[~2016-10-27 14:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-27 7:36 [PATCHv2 iproute2 net-next] tc: m_mirred: Fix parsing of 'index' optional argument Shmulik Ladkani
2016-10-27 9:46 ` Phil Sutter
2016-10-27 14:22 ` Shmulik Ladkani [this message]
2016-10-27 14:56 ` Phil Sutter
2016-10-27 19:00 ` Shmulik Ladkani
2016-11-29 20:34 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161027172239.7bf5cc40@pixies \
--to=shmulik.ladkani@gmail.com \
--cc=jhs@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=phil@nwl.cc \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).