* [patch net-next] rocker: set physical device for port netdevice
@ 2016-10-27 12:31 Jiri Pirko
2016-10-27 20:03 ` kbuild test robot
2016-10-27 20:04 ` kbuild test robot
0 siblings, 2 replies; 4+ messages in thread
From: Jiri Pirko @ 2016-10-27 12:31 UTC (permalink / raw)
To: netdev; +Cc: davem
From: Jiri Pirko <jiri@mellanox.com>
Do this so the sysfs has "device" link correctly set.
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
---
drivers/net/ethernet/rocker/rocker_main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/rocker/rocker_main.c b/drivers/net/ethernet/rocker/rocker_main.c
index 2e81b70..6d96a0c 100644
--- a/drivers/net/ethernet/rocker/rocker_main.c
+++ b/drivers/net/ethernet/rocker/rocker_main.c
@@ -2542,6 +2542,7 @@ static int rocker_probe_port(struct rocker *rocker, unsigned int port_number)
dev = alloc_etherdev(sizeof(struct rocker_port));
if (!dev)
return -ENOMEM;
+ SET_NETDEV_DEV(dev, &pdev->dev);
rocker_port = netdev_priv(dev);
rocker_port->dev = dev;
rocker_port->rocker = rocker;
--
2.5.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [patch net-next] rocker: set physical device for port netdevice
2016-10-27 12:31 [patch net-next] rocker: set physical device for port netdevice Jiri Pirko
@ 2016-10-27 20:03 ` kbuild test robot
2016-10-27 20:26 ` Jiri Pirko
2016-10-27 20:04 ` kbuild test robot
1 sibling, 1 reply; 4+ messages in thread
From: kbuild test robot @ 2016-10-27 20:03 UTC (permalink / raw)
To: Jiri Pirko; +Cc: kbuild-all, netdev, davem
[-- Attachment #1: Type: text/plain, Size: 1833 bytes --]
Hi Jiri,
[auto build test WARNING on net-next/master]
url: https://github.com/0day-ci/linux/commits/Jiri-Pirko/rocker-set-physical-device-for-port-netdevice/20161028-030044
config: tile-allmodconfig (attached as .config)
compiler: tilegx-linux-gcc (GCC) 4.6.2
reproduce:
wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=tile
All warnings (new ones prefixed by >>):
drivers/net/ethernet/rocker/rocker_main.c: In function 'rocker_probe_port':
>> drivers/net/ethernet/rocker/rocker_main.c:2545:2: warning: assignment discards 'const' qualifier from pointer target type [enabled by default]
vim +/const +2545 drivers/net/ethernet/rocker/rocker_main.c
2529 eth_hw_addr_random(rocker_port->dev);
2530 }
2531 }
2532
2533 #define ROCKER_PORT_MIN_MTU ETH_MIN_MTU
2534 #define ROCKER_PORT_MAX_MTU 9000
2535 static int rocker_probe_port(struct rocker *rocker, unsigned int port_number)
2536 {
2537 const struct pci_dev *pdev = rocker->pdev;
2538 struct rocker_port *rocker_port;
2539 struct net_device *dev;
2540 int err;
2541
2542 dev = alloc_etherdev(sizeof(struct rocker_port));
2543 if (!dev)
2544 return -ENOMEM;
> 2545 SET_NETDEV_DEV(dev, &pdev->dev);
2546 rocker_port = netdev_priv(dev);
2547 rocker_port->dev = dev;
2548 rocker_port->rocker = rocker;
2549 rocker_port->port_number = port_number;
2550 rocker_port->pport = port_number + 1;
2551
2552 err = rocker_world_check_init(rocker_port);
2553 if (err) {
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 46344 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [patch net-next] rocker: set physical device for port netdevice
2016-10-27 12:31 [patch net-next] rocker: set physical device for port netdevice Jiri Pirko
2016-10-27 20:03 ` kbuild test robot
@ 2016-10-27 20:04 ` kbuild test robot
1 sibling, 0 replies; 4+ messages in thread
From: kbuild test robot @ 2016-10-27 20:04 UTC (permalink / raw)
To: Jiri Pirko; +Cc: kbuild-all, netdev, davem
[-- Attachment #1: Type: text/plain, Size: 2152 bytes --]
Hi Jiri,
[auto build test WARNING on net-next/master]
url: https://github.com/0day-ci/linux/commits/Jiri-Pirko/rocker-set-physical-device-for-port-netdevice/20161028-030044
config: xtensa-allmodconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 4.9.0
reproduce:
wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=xtensa
All warnings (new ones prefixed by >>):
In file included from drivers/net/ethernet/rocker/rocker_main.c:21:0:
drivers/net/ethernet/rocker/rocker_main.c: In function 'rocker_probe_port':
>> include/linux/netdevice.h:2062:54: warning: assignment discards 'const' qualifier from pointer target type
#define SET_NETDEV_DEV(net, pdev) ((net)->dev.parent = (pdev))
^
>> drivers/net/ethernet/rocker/rocker_main.c:2545:2: note: in expansion of macro 'SET_NETDEV_DEV'
SET_NETDEV_DEV(dev, &pdev->dev);
^
vim +/SET_NETDEV_DEV +2545 drivers/net/ethernet/rocker/rocker_main.c
2529 eth_hw_addr_random(rocker_port->dev);
2530 }
2531 }
2532
2533 #define ROCKER_PORT_MIN_MTU ETH_MIN_MTU
2534 #define ROCKER_PORT_MAX_MTU 9000
2535 static int rocker_probe_port(struct rocker *rocker, unsigned int port_number)
2536 {
2537 const struct pci_dev *pdev = rocker->pdev;
2538 struct rocker_port *rocker_port;
2539 struct net_device *dev;
2540 int err;
2541
2542 dev = alloc_etherdev(sizeof(struct rocker_port));
2543 if (!dev)
2544 return -ENOMEM;
> 2545 SET_NETDEV_DEV(dev, &pdev->dev);
2546 rocker_port = netdev_priv(dev);
2547 rocker_port->dev = dev;
2548 rocker_port->rocker = rocker;
2549 rocker_port->port_number = port_number;
2550 rocker_port->pport = port_number + 1;
2551
2552 err = rocker_world_check_init(rocker_port);
2553 if (err) {
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 47036 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-10-27 20:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-27 12:31 [patch net-next] rocker: set physical device for port netdevice Jiri Pirko
2016-10-27 20:03 ` kbuild test robot
2016-10-27 20:26 ` Jiri Pirko
2016-10-27 20:04 ` kbuild test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).