From: David Miller <davem@davemloft.net>
To: tgraf@suug.ch
Cc: netdev@vger.kernel.org, daniel@iogearbox.net, ast@kernel.org
Subject: Re: [PATCH net-next] bpf: Print function name in addition to function id
Date: Sat, 29 Oct 2016 15:56:08 -0400 (EDT) [thread overview]
Message-ID: <20161029.155608.910725512368974977.davem@davemloft.net> (raw)
In-Reply-To: <67466f1b43b8a586bcf63fa1e5e292ed340d515c.1477560166.git.tgraf@suug.ch>
From: Thomas Graf <tgraf@suug.ch>
Date: Thu, 27 Oct 2016 11:23:51 +0200
> The verifier currently prints raw function ids when printing CALL
> instructions or when complaining:
>
> 5: (85) call 23
> unknown func 23
>
> print a meaningful function name instead:
>
> 5: (85) call bpf_redirect#23
> unknown func bpf_redirect#23
>
> Moves the function documentation to a single comment and renames all
> helpers names in the list to conform to the bpf_ prefix notation so
> they can be greped in the kernel source.
>
> Signed-off-by: Thomas Graf <tgraf@suug.ch>
> Acked-by: Daniel Borkmann <daniel@iogearbox.net>
> Acked-by: Alexei Starovoitov <ast@kernel.org>
Applied.
prev parent reply other threads:[~2016-10-29 19:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-27 9:23 [PATCH net-next] bpf: Print function name in addition to function id Thomas Graf
2016-10-29 19:56 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161029.155608.910725512368974977.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).