From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [PATCH 03/17] batman-adv: Add network_coding and mcast sysfs files to README Date: Sat, 29 Oct 2016 12:56:28 +0200 Message-ID: <20161029105628.GE1692@nanopsycho.orion> References: <20161027190150.7880-1-sw@simonwunderlich.de> <20161027190150.7880-4-sw@simonwunderlich.de> <20161029103301.GD1692@nanopsycho.orion> <22392280.4UY6GoIrAk@sven-edge> Reply-To: The list for a Better Approach To Mobile Ad-hoc Networking Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, b.a.t.m.a.n-ZwoEplunGu2X36UT3dwllkB+6BGkLq7r@public.gmane.org, davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org To: Sven Eckelmann Return-path: Content-Disposition: inline In-Reply-To: <22392280.4UY6GoIrAk@sven-edge> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: b.a.t.m.a.n-bounces-ZwoEplunGu2X36UT3dwllkB+6BGkLq7r@public.gmane.org Sender: "B.A.T.M.A.N" List-Id: netdev.vger.kernel.org Sat, Oct 29, 2016 at 12:37:07PM CEST, sven-KaDOiPu9UxWEi8DpZVb4nw@public.gmane.org wrote: >On Samstag, 29. Oktober 2016 12:33:01 CEST Jiri Pirko wrote: >[...] >> >--- a/Documentation/networking/batman-adv.txt >> >+++ b/Documentation/networking/batman-adv.txt >> >@@ -71,10 +71,11 @@ All mesh wide settings can be found in batman's own interface >> > folder: >> > >> > # ls /sys/class/net/bat0/mesh/ >> >-#aggregated_ogms distributed_arp_table gw_sel_class orig_interval >> >-#ap_isolation fragmentation hop_penalty routing_algo >> >-#bonding gw_bandwidth isolation_mark vlan0 >> >-#bridge_loop_avoidance gw_mode log_level >> >+# aggregated_ogms fragmentation isolation_mark routing_algo >> >+# ap_isolation gw_bandwidth log_level vlan0 >> >+# bonding gw_mode multicast_mode >> >+# bridge_loop_avoidance gw_sel_class network_coding >> >+# distributed_arp_table hop_penalty orig_interval >> >> I strongly believe it is a huge mistake to use sysfs for things like >> this. This should be done via generic netlink api. > >This doesn't change the problem that it is already that way. This patch >only adds the list of available files to the README. Sure. Just found out you did it like that. Therefore I commented. I suggest to rework the api to use genl entirely. > >Kind regards, > Sven