netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: mlord@pobox.com
Cc: nic_swsd@realtek.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] drivers/net/usb/r8152 fix broken rx checksums
Date: Sun, 30 Oct 2016 17:22:22 -0400 (EDT)	[thread overview]
Message-ID: <20161030.172222.1243045598122436637.davem@davemloft.net> (raw)
In-Reply-To: <987cfbab-2b48-e28c-1706-967cb2051d63@pobox.com>

From: Mark Lord <mlord@pobox.com>
Date: Wed, 26 Oct 2016 18:36:57 -0400

> Patch attached (to deal with buggy mailer) and also below for review.

Please make your mailer work properly so that you can submit
patches properly which work inline, just like every other developer
does for the kernel.

Also please format your Subject line properly, it must be of the
form:

	[PATCH net] r8152: Fix broken RX checksums.

The important parts are:

	1) "[PATCH net]"  This says that it is a patch, and that it
	   is targetting the 'net' GIT tree specifically.

	2) "r8152: "  This indicates the "subsystem" that the patch
	   specifically targets, in this case the r8152 driver.  It
	   must end with a colon character then a space.

	3) "Fix broken RX checksums."  Commit header lines and commit
	   messages are proper English, therefore sentences should
	   begin with a capitalized letter and end with a period.

Thanks.

  parent reply	other threads:[~2016-10-30 21:22 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-26 22:36 [PATCH] drivers/net/usb/r8152 fix broken rx checksums Mark Lord
2016-10-26 22:54 ` Mark Lord
2016-10-30 21:22 ` David Miller [this message]
2016-10-30 23:48   ` Paul Bolle
2016-10-30 23:28 ` [PATCH net] r8152: Fix broken RX checksums Mark Lord
2016-10-31  0:57   ` David Miller
2016-10-31  2:07     ` Mark Lord
2016-10-31  3:53       ` David Miller
2016-10-31  8:14         ` Hayes Wang
2016-10-31 13:24           ` Mark Lord
2016-11-02 18:29           ` Mark Lord
2016-11-04 12:13             ` Mark Lord
     [not found]           ` <201611030159.uA31x0np004648@rtits1.realtek.com>
2016-11-03  8:56             ` Hayes Wang
2016-11-03 11:43               ` Mark Lord
2016-11-04 13:50                 ` Mark Lord
2016-11-04 20:13                   ` Mark Lord
     [not found]                 ` <201611041425.uA4EPwCw018176@rtits1.realtek.com>
2016-11-09 13:09                   ` Hayes Wang
2016-11-09 13:19                     ` Mark Lord

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161030.172222.1243045598122436637.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mlord@pobox.com \
    --cc=netdev@vger.kernel.org \
    --cc=nic_swsd@realtek.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).