netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: John Heenan <john@zgus.com>
To: Jes Sorensen <Jes.Sorensen@redhat.com>,
	Kalle Valo <kvalo@codeaurora.org>,
	linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 1/2] rtl8xxxu: Fix for authentication failure
Date: Sun, 30 Oct 2016 20:20:46 +1000	[thread overview]
Message-ID: <20161030102046.GA5784@cube> (raw)
In-Reply-To: <cover.1477769750.git.john@zgus.com>

This fix enables the same sequence of init behaviour as the alternative
working driver for the wireless rtl8723bu IC at
https://github.com/lwfinger/rtl8723bu

For exampe rtl8xxxu_init_device is now called each time
userspace wpa_supplicant is executed instead of just once when
modprobe is executed.

Along with 'Fix for bogus data used to determine macpower',
wpa_supplicant now reliably and successfully authenticates.

For rtl8xxxu-devel branch of git.kernel.org/pub/scm/linux/kernel/git/jes/linux.git

Signed-off-by: John Heenan <john@zgus.com>
---
 drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
index 04141e5..f25b4df 100644
--- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
+++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
@@ -5779,6 +5779,11 @@ static int rtl8xxxu_start(struct ieee80211_hw *hw)
 
 	ret = 0;
 
+	ret = rtl8xxxu_init_device(hw);
+	if (ret)
+		goto error_out;
+
+
 	init_usb_anchor(&priv->rx_anchor);
 	init_usb_anchor(&priv->tx_anchor);
 	init_usb_anchor(&priv->int_anchor);
@@ -6080,10 +6085,6 @@ static int rtl8xxxu_probe(struct usb_interface *interface,
 		goto exit;
 	}
 
-	ret = rtl8xxxu_init_device(hw);
-	if (ret)
-		goto exit;
-
 	hw->wiphy->max_scan_ssids = 1;
 	hw->wiphy->max_scan_ie_len = IEEE80211_MAX_DATA_LEN;
 	hw->wiphy->interface_modes = BIT(NL80211_IFTYPE_STATION);
-- 
2.10.1

       reply	other threads:[~2016-10-30 10:20 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1477769750.git.john@zgus.com>
2016-10-30 10:20 ` John Heenan [this message]
2016-11-03  1:00   ` [PATCH 1/2] rtl8xxxu: Fix for authentication failure Larry Finger
     [not found]     ` <8dba6346-332e-84e6-89b2-02033a449f25-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
2016-11-03  7:10       ` John Heenan
2016-11-03 15:39         ` Larry Finger
2016-10-30 10:21 ` [PATCH 2/2] rtl8xxxu: Fix for bogus data used to determine macpower John Heenan
2016-10-30 12:00   ` Jes Sorensen
2016-10-30 13:56     ` John Heenan
2016-10-30 23:02       ` Jes Sorensen
2016-11-03  8:41         ` Joe Perches
2016-11-03 15:43           ` Larry Finger
     [not found]           ` <1478162497.1924.16.camel-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2016-11-04 13:56             ` Jes Sorensen
2016-11-03  1:00   ` Larry Finger
2016-11-03  2:58     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161030102046.GA5784@cube \
    --to=john@zgus.com \
    --cc=Jes.Sorensen@redhat.com \
    --cc=kvalo@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).