From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org, maze@google.com, willemb@google.com
Subject: Re: [PATCH net] net: mangle zero checksum in skb_checksum_help()
Date: Mon, 31 Oct 2016 15:29:32 -0400 (EDT) [thread overview]
Message-ID: <20161031.152932.840383254132956388.davem@davemloft.net> (raw)
In-Reply-To: <1477764156.7065.282.camel@edumazet-glaptop3.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Sat, 29 Oct 2016 11:02:36 -0700
> From: Eric Dumazet <edumazet@google.com>
>
> Sending zero checksum is ok for TCP, but not for UDP.
>
> UDPv6 receiver should by default drop a frame with a 0 checksum,
> and UDPv4 would not verify the checksum and might accept a corrupted
> packet.
>
> Simply replace such checksum by 0xffff, regardless of transport.
>
> This error was caught on SIT tunnels, but seems generic.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2016-10-31 19:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-29 18:02 [PATCH net] net: mangle zero checksum in skb_checksum_help() Eric Dumazet
2016-10-29 18:30 ` Maciej Żenczykowski
2016-10-31 19:29 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161031.152932.840383254132956388.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=maze@google.com \
--cc=netdev@vger.kernel.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).