netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: marcelo.leitner@gmail.com
Cc: lucien.xin@gmail.com, netdev@vger.kernel.org,
	linux-sctp@vger.kernel.org, vyasevich@gmail.com,
	nhorman@tuxdriver.com
Subject: Re: [PATCHv2 net] sctp: return back transport in __sctp_rcv_init_lookup
Date: Mon, 31 Oct 2016 16:30:44 -0400 (EDT)	[thread overview]
Message-ID: <20161031.163044.769708932828537399.davem@davemloft.net> (raw)
In-Reply-To: <20161031201302.GB8514@localhost.localdomain>

From: marcelo.leitner@gmail.com
Date: Mon, 31 Oct 2016 18:13:02 -0200

> On Mon, Oct 31, 2016 at 03:53:48PM -0400, David Miller wrote:
>> From: Xin Long <lucien.xin@gmail.com>
>> Date: Mon, 31 Oct 2016 00:42:35 +0800
>> 
>> > Prior to this patch, it used a local variable to save the transport that is
>> > looked up by __sctp_lookup_association(), and didn't return it back. But in
>> > sctp_rcv, it is used to initialize chunk->transport. So when hitting this,
>> > even if it found the transport, it was still initializing chunk->transport
>> > with null instead.
>> > 
>> > This patch is to return the transport back through transport pointer
>> > that is from __sctp_rcv_lookup_harder().
>> > 
>> > Signed-off-by: Xin Long <lucien.xin@gmail.com>
>> 
>> So do I apply this to 'net'?  If so I'd like to see explicit ACKs.
>> 
>> Thanks.
> 
> No. Xin reposted the patchset with this patch updated instead, so please
> ignore this one. Thanks.
> 
> Patchset named: [PATCHv2 net 0/3] sctp: a bunch of fixes by holding transport

I got this now, thanks.

      reply	other threads:[~2016-10-31 20:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-30 16:42 [PATCHv2 net] sctp: return back transport in __sctp_rcv_init_lookup Xin Long
2016-10-31 10:51 ` Marcelo Ricardo Leitner
2016-10-31 12:25   ` Xin Long
2016-10-31 19:53 ` David Miller
2016-10-31 20:13   ` marcelo.leitner
2016-10-31 20:30     ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161031.163044.769708932828537399.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=linux-sctp@vger.kernel.org \
    --cc=lucien.xin@gmail.com \
    --cc=marcelo.leitner@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@tuxdriver.com \
    --cc=vyasevich@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).