From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCHv2 net] sctp: return back transport in __sctp_rcv_init_lookup Date: Mon, 31 Oct 2016 16:30:44 -0400 (EDT) Message-ID: <20161031.163044.769708932828537399.davem@davemloft.net> References: <8d72a86988a2c16c74c45c52dafbf2bbbe9c3b4d.1477845755.git.lucien.xin@gmail.com> <20161031.155348.689672413057243931.davem@davemloft.net> <20161031201302.GB8514@localhost.localdomain> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: lucien.xin@gmail.com, netdev@vger.kernel.org, linux-sctp@vger.kernel.org, vyasevich@gmail.com, nhorman@tuxdriver.com To: marcelo.leitner@gmail.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:57578 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S946373AbcJaUaq (ORCPT ); Mon, 31 Oct 2016 16:30:46 -0400 In-Reply-To: <20161031201302.GB8514@localhost.localdomain> Sender: netdev-owner@vger.kernel.org List-ID: From: marcelo.leitner@gmail.com Date: Mon, 31 Oct 2016 18:13:02 -0200 > On Mon, Oct 31, 2016 at 03:53:48PM -0400, David Miller wrote: >> From: Xin Long >> Date: Mon, 31 Oct 2016 00:42:35 +0800 >> >> > Prior to this patch, it used a local variable to save the transport that is >> > looked up by __sctp_lookup_association(), and didn't return it back. But in >> > sctp_rcv, it is used to initialize chunk->transport. So when hitting this, >> > even if it found the transport, it was still initializing chunk->transport >> > with null instead. >> > >> > This patch is to return the transport back through transport pointer >> > that is from __sctp_rcv_lookup_harder(). >> > >> > Signed-off-by: Xin Long >> >> So do I apply this to 'net'? If so I'd like to see explicit ACKs. >> >> Thanks. > > No. Xin reposted the patchset with this patch updated instead, so please > ignore this one. Thanks. > > Patchset named: [PATCHv2 net 0/3] sctp: a bunch of fixes by holding transport I got this now, thanks.