From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ido Schimmel Subject: Re: [patch net] mlxsw: spectrum: Fix incorrect reuse of MID entries Date: Mon, 31 Oct 2016 22:36:16 +0200 Message-ID: <20161031203616.3yuvu2l4k3xf6yb7@splinter> References: <1477818562-30185-1-git-send-email-jiri@resnulli.us> <20161031.153606.989406936490082438.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: jiri@resnulli.us, netdev@vger.kernel.org, eladr@mellanox.com, idosch@mellanox.com, yotamg@mellanox.com, nogahf@mellanox.com, ogerlitz@mellanox.com To: David Miller Return-path: Received: from out2-smtp.messagingengine.com ([66.111.4.26]:50159 "EHLO out2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S946369AbcJaUgo (ORCPT ); Mon, 31 Oct 2016 16:36:44 -0400 Content-Disposition: inline In-Reply-To: <20161031.153606.989406936490082438.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: Hi, On Mon, Oct 31, 2016 at 03:36:06PM -0400, David Miller wrote: > From: Jiri Pirko > Date: Sun, 30 Oct 2016 10:09:22 +0100 > > > From: Ido Schimmel > > > > In the device, a MID entry represents a group of local ports, which can > > later be bound to a MDB entry. > > > > The lookup of an existing MID entry is currently done using the provided > > MC MAC address and VID, from the Linux bridge. However, this can result > > in an incorrect reuse of the same MID index in different VLAN-unaware > > bridges (same IP MC group and VID 0). > > > > Fix this by performing the lookup based on FID instead of VID, which is > > unique across different bridges. > > > > Fixes: 3a49b4fde2a1 ("mlxsw: Adding layer 2 multicast support") > > Signed-off-by: Ido Schimmel > > Acked-by: Elad Raz > > Signed-off-by: Jiri Pirko > > Applied, should I queue this up for -stable? I don't think it's necessary, but thanks for asking! We recently picked up the habit of noting what we would like to see in -stable.