From: David Miller <davem@davemloft.net>
To: dsa@cumulusnetworks.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net: Enable support for VRF with ipv4 multicast
Date: Tue, 01 Nov 2016 11:54:57 -0400 (EDT) [thread overview]
Message-ID: <20161101.115457.1305736308724331371.davem@davemloft.net> (raw)
In-Reply-To: <1477954440-12339-1-git-send-email-dsa@cumulusnetworks.com>
From: David Ahern <dsa@cumulusnetworks.com>
Date: Mon, 31 Oct 2016 15:54:00 -0700
> Enable support for IPv4 multicast:
> - similar to unicast the flow struct is updated to L3 master device
> if relevant prior to calling fib_rules_lookup. The table id is saved
> to the lookup arg so the rule action for ipmr can return the table
> associated with the device.
>
> - ip_mr_forward needs to check for master device mismatch as well
> since the skb->dev is set to it
>
> - allow multicast address on VRF device for Rx by checking for the
> daddr in the VRF device as well as the original ingress device
>
> - on Tx need to drop to __mkroute_output when FIB lookup fails for
> multicast destination address.
>
> - if CONFIG_IP_MROUTE_MULTIPLE_TABLES is enabled VRF driver creates
> IPMR FIB rules on first device create similar to FIB rules. In
> addition the VRF driver does not divert IPv4 multicast packets:
> it breaks on Tx since the fib lookup fails on the mcast address.
>
> With this patch, ipmr forwarding and local rx/tx work.
>
> Signed-off-by: David Ahern <dsa@cumulusnetworks.com>
Applied, thanks David.
prev parent reply other threads:[~2016-11-01 15:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-31 22:54 [PATCH net-next] net: Enable support for VRF with ipv4 multicast David Ahern
2016-11-01 15:54 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161101.115457.1305736308724331371.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dsa@cumulusnetworks.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).