From: Jon Mason <jon.mason@broadcom.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: David Miller <davem@davemloft.net>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Florian Fainelli <f.fainelli@gmail.com>,
devicetree@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com, rafal@milecki.pl,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 2/6] net: phy: broadcom: Add BCM54810 PHY entry
Date: Tue, 1 Nov 2016 15:59:48 -0400 [thread overview]
Message-ID: <20161101195946.GA26962@broadcom.com> (raw)
In-Reply-To: <20161101184639.GI10785@lunn.ch>
On Tue, Nov 01, 2016 at 07:46:39PM +0100, Andrew Lunn wrote:
> Hi Jon
>
> > @@ -56,6 +57,8 @@
> > #define PHY_BRCM_EXT_IBND_TX_ENABLE 0x00002000
> > #define PHY_BRCM_CLEAR_RGMII_MODE 0x00004000
> > #define PHY_BRCM_DIS_TXCRXC_NOENRGY 0x00008000
> > +#define PHY_BRCM_EXP_LANE_SWAP 0x00010000
> > +
>
> You define this, but don't use it...
Good catch. Cruft from the last patch. I'll sendout a quick v4 to
address this and the missing Documentation patch.
>
> Andrew
next prev parent reply other threads:[~2016-11-01 19:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-01 17:51 [PATCH v3 0/6] add NS2 support to bgmac Jon Mason
2016-11-01 17:51 ` [PATCH v3 1/6] net: phy: broadcom: add bcm54xx_auxctl_read Jon Mason
2016-11-01 17:51 ` [PATCH v3 2/6] net: phy: broadcom: Add BCM54810 PHY entry Jon Mason
2016-11-01 18:46 ` Andrew Lunn
2016-11-01 19:59 ` Jon Mason [this message]
2016-11-01 17:51 ` [PATCH v3 3/6] Documentation: devicetree: net: add NS2 bindings to amac Jon Mason
2016-11-01 17:51 ` [PATCH v3 4/6] net: ethernet: bgmac: device tree phy enablement Jon Mason
[not found] ` <1478022694-25308-1-git-send-email-jon.mason-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2016-11-01 17:51 ` [PATCH v3 5/6] net: ethernet: bgmac: add NS2 support Jon Mason
2016-11-01 17:51 ` [PATCH v3 6/6] arm64: dts: NS2: add AMAC ethernet support Jon Mason
2016-11-01 18:01 ` [PATCH v3 0/6] add NS2 support to bgmac Scott Branden
2016-11-01 20:01 ` Jon Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161101195946.GA26962@broadcom.com \
--to=jon.mason@broadcom.com \
--cc=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=rafal@milecki.pl \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).