From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next] sctp: clean up sctp_packet_transmit Date: Wed, 02 Nov 2016 15:03:34 -0400 (EDT) Message-ID: <20161102.150334.1394712647657902885.davem@davemloft.net> References: <407056b761e77ecbd43603a17099bb9309a9a8ac.1477932581.git.lucien.xin@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linux-sctp@vger.kernel.org, marcelo.leitner@gmail.com, nhorman@tuxdriver.com, vyasevich@gmail.com To: lucien.xin@gmail.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:45022 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754175AbcKBTDg (ORCPT ); Wed, 2 Nov 2016 15:03:36 -0400 In-Reply-To: <407056b761e77ecbd43603a17099bb9309a9a8ac.1477932581.git.lucien.xin@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Xin Long Date: Tue, 1 Nov 2016 00:49:41 +0800 > After adding sctp gso, sctp_packet_transmit is a quite big function now. > > This patch is to extract the codes for packing packet to sctp_packet_pack > from sctp_packet_transmit, and add some comments, simplify the err path by > freeing auth chunk when freeing packet chunk_list in out path and freeing > head skb early if it fails to pack packet. > > Signed-off-by: Xin Long Applied.