* [patch net-next 2/2] [PATCH] net: ip, raw_diag -- Use jump for exiting from nested loop
@ 2016-11-02 12:36 Cyrill Gorcunov
2016-11-02 14:56 ` David Ahern
0 siblings, 1 reply; 2+ messages in thread
From: Cyrill Gorcunov @ 2016-11-02 12:36 UTC (permalink / raw)
To: netdev
Cc: Eric Dumazet, David S. Miller, David Ahern, Andrey Vagin,
Stephen Hemminger, Cyrill Gorcunov
[-- Attachment #1: inet-diag-raw-break-loop --]
[-- Type: text/plain, Size: 906 bytes --]
I managed to miss that sk_for_each is called under "for"
cycle so need to use goto here to return matching socket.
CC: David S. Miller <davem@davemloft.net>
CC: Eric Dumazet <eric.dumazet@gmail.com>
CC: David Ahern <dsa@cumulusnetworks.com>
CC: Andrey Vagin <avagin@openvz.org>
CC: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
---
net/ipv4/raw_diag.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Index: linux-ml.git/net/ipv4/raw_diag.c
===================================================================
--- linux-ml.git.orig/net/ipv4/raw_diag.c
+++ linux-ml.git/net/ipv4/raw_diag.c
@@ -79,10 +79,11 @@ static struct sock *raw_sock_get(struct
* hashinfo->lock here.
*/
sock_hold(sk);
- break;
+ goto out_unlock;
}
}
}
+out_unlock:
read_unlock(&hashinfo->lock);
return sk ? sk : ERR_PTR(-ENOENT);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patch net-next 2/2] [PATCH] net: ip, raw_diag -- Use jump for exiting from nested loop
2016-11-02 12:36 [patch net-next 2/2] [PATCH] net: ip, raw_diag -- Use jump for exiting from nested loop Cyrill Gorcunov
@ 2016-11-02 14:56 ` David Ahern
0 siblings, 0 replies; 2+ messages in thread
From: David Ahern @ 2016-11-02 14:56 UTC (permalink / raw)
To: Cyrill Gorcunov, netdev
Cc: Eric Dumazet, David S. Miller, Andrey Vagin, Stephen Hemminger
On 11/2/16 6:36 AM, Cyrill Gorcunov wrote:
> I managed to miss that sk_for_each is called under "for"
> cycle so need to use goto here to return matching socket.
>
> CC: David S. Miller <davem@davemloft.net>
> CC: Eric Dumazet <eric.dumazet@gmail.com>
> CC: David Ahern <dsa@cumulusnetworks.com>
> CC: Andrey Vagin <avagin@openvz.org>
> CC: Stephen Hemminger <stephen@networkplumber.org>
> Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
> ---
> net/ipv4/raw_diag.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Acked-by: David Ahern <dsa@cumulusnetworks.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-11-02 14:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-02 12:36 [patch net-next 2/2] [PATCH] net: ip, raw_diag -- Use jump for exiting from nested loop Cyrill Gorcunov
2016-11-02 14:56 ` David Ahern
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).