netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: dsa@cumulusnetworks.com
Cc: netdev@vger.kernel.org, andreyknvl@google.com
Subject: Re: [PATCH] net: tcp: check skb is non-NULL for exact match on lookups
Date: Thu, 03 Nov 2016 16:06:25 -0400 (EDT)	[thread overview]
Message-ID: <20161103.160625.1817596298692975304.davem@davemloft.net> (raw)
In-Reply-To: <1478113705-16174-1-git-send-email-dsa@cumulusnetworks.com>

From: David Ahern <dsa@cumulusnetworks.com>
Date: Wed,  2 Nov 2016 12:08:25 -0700

> Andrey reported the following error report while running the syzkaller
> fuzzer:
 ...
> MD5 has a code path that calls __inet_lookup_listener with a null skb,
> so inet{6}_exact_dif_match needs to check skb against null before pulling
> the flag.
> 
> Fixes: a04a480d4392 ("net: Require exact match for TCP socket lookups if
>        dif is l3mdev")
> Reported-by: Andrey Konovalov <andreyknvl@google.com>
> Signed-off-by: David Ahern <dsa@cumulusnetworks.com>
> ---
> Dave: commit a04a480d4392 was queued for stable, so this needs to follow it.

Applied and queued up for -stable, thanks.

      parent reply	other threads:[~2016-11-03 20:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-02 19:08 [PATCH] net: tcp: check skb is non-NULL for exact match on lookups David Ahern
2016-11-02 20:13 ` Andrey Konovalov
2016-11-02 21:05   ` David Ahern
2016-11-03 20:06 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161103.160625.1817596298692975304.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=andreyknvl@google.com \
    --cc=dsa@cumulusnetworks.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).