From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: andreyknvl@google.com, herbert@gondor.apana.org.au,
akpm@linux-foundation.org, decot@googlers.com,
dmitrijs.ivanovs@ubnt.com, edumazet@google.com, fw@strlen.de,
grose@lightfleet.com, johannes.berg@intel.com,
matti.vaittinen@nokia.com, pshelar@ovn.org,
stephen@networkplumber.org, tom@herbertland.com,
tycho.andersen@canonical.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, syzkaller@googlegroups.com,
kcc@google.com, glider@google.com, dvyukov@google.com
Subject: Re: [PATCH net] netlink: netlink_diag_dump() runs without locks
Date: Thu, 03 Nov 2016 16:20:19 -0400 (EDT) [thread overview]
Message-ID: <20161103.162019.2109271991889343912.davem@davemloft.net> (raw)
In-Reply-To: <1478143280.7065.427.camel@edumazet-glaptop3.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 02 Nov 2016 20:21:20 -0700
> From: Eric Dumazet <edumazet@google.com>
>
> A recent commit removed locking from netlink_diag_dump() but forgot
> one error case.
...
> Fixes: ad202074320c ("netlink: Use rhashtable walk interface in diag dump")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Reported-by: Andrey Konovalov <andreyknvl@google.com>
> Tested-by: Andrey Konovalov <andreyknvl@google.com>
Applied.
next prev parent reply other threads:[~2016-11-03 20:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-19 14:13 net/netlink: null-ptr-deref in netlink_dump/lock_acquire Andrey Konovalov
2016-11-03 0:15 ` Andrey Konovalov
2016-11-03 2:36 ` Andrey Konovalov
2016-11-03 2:58 ` Eric Dumazet
2016-11-03 3:08 ` Andrey Konovalov
2016-11-03 3:21 ` [PATCH net] netlink: netlink_diag_dump() runs without locks Eric Dumazet
2016-11-03 20:20 ` David Miller [this message]
2016-11-03 17:21 ` net/netlink: null-ptr-deref in netlink_dump/lock_acquire Andrey Konovalov
2016-11-25 18:57 ` Dmitry Vyukov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161103.162019.2109271991889343912.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@google.com \
--cc=decot@googlers.com \
--cc=dmitrijs.ivanovs@ubnt.com \
--cc=dvyukov@google.com \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=fw@strlen.de \
--cc=glider@google.com \
--cc=grose@lightfleet.com \
--cc=herbert@gondor.apana.org.au \
--cc=johannes.berg@intel.com \
--cc=kcc@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matti.vaittinen@nokia.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@ovn.org \
--cc=stephen@networkplumber.org \
--cc=syzkaller@googlegroups.com \
--cc=tom@herbertland.com \
--cc=tycho.andersen@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).