* [PATCH 1/2] ethernet: stmmac: make DWMAC_STM32 depend on it's associated SoC
@ 2016-11-06 20:04 Peter Robinson
2016-11-07 2:41 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Peter Robinson @ 2016-11-06 20:04 UTC (permalink / raw)
To: Maxime Coquelin, Alexandre Torgue, Giuseppe Cavallaro, netdev
Cc: Peter Robinson
There's not much point, except compile test, enabling the stmmac
platform drivers unless the STM32 SoC is enabled. It's not
useful without it.
Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
---
drivers/net/ethernet/stmicro/stmmac/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/Kconfig b/drivers/net/ethernet/stmicro/stmmac/Kconfig
index 3818c5e..4b78168 100644
--- a/drivers/net/ethernet/stmicro/stmmac/Kconfig
+++ b/drivers/net/ethernet/stmicro/stmmac/Kconfig
@@ -107,7 +107,7 @@ config DWMAC_STI
config DWMAC_STM32
tristate "STM32 DWMAC support"
default ARCH_STM32
- depends on OF && HAS_IOMEM
+ depends on OF && HAS_IOMEM && (ARCH_STM32 || COMPILE_TEST)
select MFD_SYSCON
---help---
Support for ethernet controller on STM32 SOCs.
--
2.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] ethernet: stmmac: make DWMAC_STM32 depend on it's associated SoC
2016-11-06 20:04 [PATCH 1/2] ethernet: stmmac: make DWMAC_STM32 depend on it's associated SoC Peter Robinson
@ 2016-11-07 2:41 ` David Miller
2016-11-16 14:01 ` Peter Robinson
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2016-11-07 2:41 UTC (permalink / raw)
To: pbrobinson; +Cc: mcoquelin.stm32, alexandre.torgue, peppe.cavallaro, netdev
From: Peter Robinson <pbrobinson@gmail.com>
Date: Sun, 6 Nov 2016 20:04:37 +0000
> There's not much point, except compile test, enabling the stmmac
> platform drivers unless the STM32 SoC is enabled. It's not
> useful without it.
>
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
Please don't post just some of the patches in a patch series.
Always post the complete series, with a proper "[PATCH 0/2] ..."
posting at the beginning.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] ethernet: stmmac: make DWMAC_STM32 depend on it's associated SoC
2016-11-07 2:41 ` David Miller
@ 2016-11-16 14:01 ` Peter Robinson
0 siblings, 0 replies; 3+ messages in thread
From: Peter Robinson @ 2016-11-16 14:01 UTC (permalink / raw)
To: David Miller; +Cc: mcoquelin.stm32, alexandre.torgue, peppe.cavallaro, netdev
On Mon, Nov 7, 2016 at 2:41 AM, David Miller <davem@davemloft.net> wrote:
> From: Peter Robinson <pbrobinson@gmail.com>
> Date: Sun, 6 Nov 2016 20:04:37 +0000
>
>> There's not much point, except compile test, enabling the stmmac
>> platform drivers unless the STM32 SoC is enabled. It's not
>> useful without it.
>>
>> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
>
> Please don't post just some of the patches in a patch series.
>
> Always post the complete series, with a proper "[PATCH 0/2] ..."
> posting at the beginning.
Sorry, it was a stm branch, I should have broke it our differently. I
can recompose and send this one again on it's own.
Peter
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-11-16 14:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-06 20:04 [PATCH 1/2] ethernet: stmmac: make DWMAC_STM32 depend on it's associated SoC Peter Robinson
2016-11-07 2:41 ` David Miller
2016-11-16 14:01 ` Peter Robinson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).