From: David Miller <davem@davemloft.net>
To: fgao@ikuai8.com
Cc: kaber@trash.net, netdev@vger.kernel.org, gfree.wind@gmail.com
Subject: Re: [PATCH net 1/1] driver: macvlan: Destroy new macvlan port if macvlan_common_newlink failed.
Date: Mon, 07 Nov 2016 20:33:32 -0500 (EST) [thread overview]
Message-ID: <20161107.203332.1849719163992933801.davem@davemloft.net> (raw)
In-Reply-To: <1478226529-26766-1-git-send-email-fgao@ikuai8.com>
From: fgao@ikuai8.com
Date: Fri, 4 Nov 2016 10:28:49 +0800
> From: Gao Feng <fgao@ikuai8.com>
>
> When there is no existing macvlan port in lowdev, one new macvlan port
> would be created. But it doesn't be destoried when something failed later.
> It casues some memleak.
>
> Now add one flag to indicate if new macvlan port is created.
>
> Signed-off-by: Gao Feng <fgao@ikuai8.com>
You need to be more patient, it sometimes take several days before
your get patch reviewed or applied. Sometimes nobody reviews a change
for some time because it is obscure or everyone is busy.
All patches are tracked in patchwork, so it is never an issue of a
change getting "lost". Therefore, it never makes sense to ping the
list again and ask if a change is "ok".
Personally, when people ping like that, it makes me want to review
that patch _less_ not more. So please do not do it.
Thank you.
next prev parent reply other threads:[~2016-11-08 1:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-04 2:28 [PATCH net 1/1] driver: macvlan: Destroy new macvlan port if macvlan_common_newlink failed fgao
2016-11-07 13:11 ` Feng Gao
2016-11-08 1:33 ` David Miller [this message]
2016-11-08 3:22 ` Gao Feng
2016-11-09 18:18 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161107.203332.1849719163992933801.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=fgao@ikuai8.com \
--cc=gfree.wind@gmail.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).