From: Stephen Suryaputra Lin <stephen.suryaputra.lin@gmail.com>
To: netdev@vger.kernel.org
Subject: Re: [PATCH net] Fixes: 5943634fc559 ("ipv4: Maintain redirect and PMTU info in struct rtable again.")
Date: Mon, 7 Nov 2016 18:05:33 -0500 [thread overview]
Message-ID: <20161107230533.GA16422@ssuryaputra-desktop> (raw)
In-Reply-To: <20161107.112016.598403889913912857.davem@davemloft.net>
I did the temporary clearing/restoring rt_gateway following the deleted
function check_peer_redir(). But, looking again at the function the
assigning of peer->redirect_learned.a4 to rt_gateway can be permanent
because restoring to the old_gw only happens on errors.
I have updated the patch to use __ipv4_neigh_lookup().
Thank you.
On Mon, Nov 07, 2016 at 11:20:16AM -0500, David Miller wrote:
> From: Eric Dumazet <eric.dumazet@gmail.com>
> Date: Mon, 07 Nov 2016 08:08:52 -0800
>
> > In any case, rt is a shared object at that time, so even temporarily
> > clearing/restoring rt_gateway seems wrong to me.
> >
> > I would rather call __ipv4_neigh_lookup(dst->dev, new_gw) directly at
> > this point.
>
> Agreed.
prev parent reply other threads:[~2016-11-07 23:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-07 15:04 [PATCH net] Fixes: 5943634fc559 ("ipv4: Maintain redirect and PMTU info in struct rtable again.") Stephen Suryaputra Lin
2016-11-07 16:08 ` Eric Dumazet
2016-11-07 16:20 ` David Miller
2016-11-07 23:05 ` Stephen Suryaputra Lin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161107230533.GA16422@ssuryaputra-desktop \
--to=stephen.suryaputra.lin@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).