Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: Yuval.Mintz@cavium.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] qed: Prevent stack corruption on MFW interaction
Date: Wed, 09 Nov 2016 13:27:45 -0500 (EST)	[thread overview]
Message-ID: <20161109.132745.2191587840450609497.davem@davemloft.net> (raw)
In-Reply-To: <1478445147-23163-1-git-send-email-Yuval.Mintz@cavium.com>

From: Yuval Mintz <Yuval.Mintz@cavium.com>
Date: Sun, 6 Nov 2016 17:12:27 +0200

> Driver uses a union for copying data to & from management firmware
> when interacting with it.
> Problem is that the function always copies sizeof(union) while commit
> 2edbff8dcb5d ("qed: Learn resources from management firmware") is casting
> a union elements which is of smaller size [24-byte instead of 88-bytes].
> 
> Also, the union contains some inappropriate elements which increase its
> size [should have been 32-bytes]. While this shouldn't corrupt other
> PF messages to the MFW [as management firmware enforces permissions so
> that each PF is allowed to write only to its own mailbox] we fix this
> here as well.
> 
> Fixes: 2edbff8dcb5d ("qed: Learn resources from management firmware")
> Signed-off-by: Yuval Mintz <Yuval.Mintz@cavium.com>

Applied.

      parent reply	other threads:[~2016-11-09 18:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-06 15:12 [PATCH net-next] qed: Prevent stack corruption on MFW interaction Yuval Mintz
2016-11-07 12:17 ` David Laight
2016-11-07 12:25   ` Mintz, Yuval
2016-11-09 18:27 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161109.132745.2191587840450609497.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=Yuval.Mintz@cavium.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox