* [PATCH net] Revert "net/mlx4_en: Fix panic during reboot"
@ 2016-11-06 16:05 Tariq Toukan
2016-11-09 18:30 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Tariq Toukan @ 2016-11-06 16:05 UTC (permalink / raw)
To: David S. Miller
Cc: netdev, Eran Ben Elisha, Eugenia Emantayev, Saeed Mahameed,
Tariq Toukan
This reverts commit 9d2afba058722d40cc02f430229c91611c0e8d16.
The original issue would possibly exist if an external module
tried calling our "ethtool_ops" without checking if it still
exists.
The right way of solving it is by simply doing the check in
the caller side.
Currently, no action is required as there's no such use case.
Signed-off-by: Tariq Toukan <tariqt@mellanox.com>
---
drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
index 12c99a2655f2..3a47e83d3e07 100644
--- a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
+++ b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
@@ -2202,7 +2202,6 @@ void mlx4_en_destroy_netdev(struct net_device *dev)
if (!shutdown)
free_netdev(dev);
- dev->ethtool_ops = NULL;
}
static int mlx4_en_change_mtu(struct net_device *dev, int new_mtu)
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] Revert "net/mlx4_en: Fix panic during reboot"
2016-11-06 16:05 [PATCH net] Revert "net/mlx4_en: Fix panic during reboot" Tariq Toukan
@ 2016-11-09 18:30 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2016-11-09 18:30 UTC (permalink / raw)
To: tariqt; +Cc: netdev, eranbe, eugenia, saeedm
From: Tariq Toukan <tariqt@mellanox.com>
Date: Sun, 6 Nov 2016 18:05:06 +0200
> This reverts commit 9d2afba058722d40cc02f430229c91611c0e8d16.
>
> The original issue would possibly exist if an external module
> tried calling our "ethtool_ops" without checking if it still
> exists.
>
> The right way of solving it is by simply doing the check in
> the caller side.
> Currently, no action is required as there's no such use case.
>
> Signed-off-by: Tariq Toukan <tariqt@mellanox.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-11-09 18:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-06 16:05 [PATCH net] Revert "net/mlx4_en: Fix panic during reboot" Tariq Toukan
2016-11-09 18:30 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).