From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net-gro: avoid reorders
Date: Wed, 09 Nov 2016 18:50:00 -0500 (EST) [thread overview]
Message-ID: <20161109.185000.45567817803684243.davem@davemloft.net> (raw)
In-Reply-To: <1478545947.17367.10.camel@edumazet-glaptop3.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Mon, 07 Nov 2016 11:12:27 -0800
> From: Eric Dumazet <edumazet@google.com>
>
> Receiving a GSO packet in dev_gro_receive() is not uncommon
> in stacked devices, or devices partially implementing LRO/GRO
> like bnx2x. GRO is implementing the aggregation the device
> was not able to do itself.
>
> Current code causes reorders, like in following case :
>
> For a given flow where sender sent 3 packets P1,P2,P3,P4
>
> Receiver might receive P1 as a single packet, stored in GRO engine.
>
> Then P2-P4 are received as a single GSO packet, immediately given to
> upper stack, while P1 is held in GRO engine.
>
> This patch will make sure P1 is given to upper stack, then P2-P4
> immediately after.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied.
prev parent reply other threads:[~2016-11-09 23:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-07 19:12 [PATCH net-next] net-gro: avoid reorders Eric Dumazet
2016-11-09 23:50 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161109.185000.45567817803684243.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox