From: David Miller <davem@davemloft.net>
To: jiri@resnulli.us
Cc: netdev@vger.kernel.org, yotamg@mellanox.com, idosch@mellanox.com,
eladr@mellanox.com, nogahf@mellanox.com, ogerlitz@mellanox.com,
jhs@mojatatu.com, geert+renesas@glider.be,
stephen@networkplumber.org, xiyou.wangcong@gmail.com,
linux@roeck-us.net, roopa@cumulusnetworks.com
Subject: Re: [patch net-next 1/8] Introduce ife encapsulation module
Date: Thu, 10 Nov 2016 14:17:31 -0500 (EST) [thread overview]
Message-ID: <20161110.141731.1693686577994851858.davem@davemloft.net> (raw)
In-Reply-To: <1478776988-5400-2-git-send-email-jiri@resnulli.us>
From: Jiri Pirko <jiri@resnulli.us>
Date: Thu, 10 Nov 2016 12:23:01 +0100
> +void *ife_encode(struct sk_buff *skb, u16 metalen)
metalen is u16
> + metalen = htons(metalen);
htons() returns be16.
> +int ife_tlv_meta_encode(void *skbdata, u16 attrtype, u16 dlen, const void *dval)
> +{
> + u32 *tlv = (u32 *) (skbdata);
...
> + *tlv = htonl(htlv);
Similar situation here.
next prev parent reply other threads:[~2016-11-10 19:18 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-10 11:23 [patch net-next 0/8] Add support for offloading packet-sampling Jiri Pirko
2016-11-10 11:23 ` [patch net-next 1/8] Introduce ife encapsulation module Jiri Pirko
2016-11-10 19:17 ` David Miller [this message]
2016-11-10 19:52 ` Yotam Gigi
2016-11-10 11:23 ` [patch net-next 2/8] act_ife: Change to use ife module Jiri Pirko
2016-11-10 11:23 ` [patch net-next 3/8] net: ife: Introduce new metadata tlv types Jiri Pirko
2016-11-10 11:23 ` [patch net-next 4/8] net: ife: Introduce packet info packing method Jiri Pirko
2016-11-10 11:23 ` [patch net-next 5/8] Introduce sample tc action Jiri Pirko
2016-11-10 19:35 ` John Fastabend
2016-11-10 19:38 ` John Fastabend
2016-11-10 19:58 ` Yotam Gigi
2016-11-10 20:16 ` John Fastabend
2016-11-11 8:28 ` Yotam Gigi
2016-11-11 12:43 ` Simon Horman
2016-11-11 14:52 ` John Fastabend
2016-11-11 17:47 ` David Miller
2016-11-11 16:34 ` Yotam Gigi
2016-11-10 11:23 ` [patch net-next 6/8] tc: sample: Add sequence number and sampler_id fields Jiri Pirko
2016-11-10 11:23 ` [patch net-next 7/8] mlxsw: reg: add the Monitoring Packet Sampling Configuration Register Jiri Pirko
2016-11-10 11:23 ` [patch net-next 8/8] mlxsw: packet sample: Add packet sample offloading support Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161110.141731.1693686577994851858.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eladr@mellanox.com \
--cc=geert+renesas@glider.be \
--cc=idosch@mellanox.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=linux@roeck-us.net \
--cc=netdev@vger.kernel.org \
--cc=nogahf@mellanox.com \
--cc=ogerlitz@mellanox.com \
--cc=roopa@cumulusnetworks.com \
--cc=stephen@networkplumber.org \
--cc=xiyou.wangcong@gmail.com \
--cc=yotamg@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).