From: Jiri Benc <jbenc@redhat.com>
To: Pravin Shelar <pshelar@ovn.org>
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next v2 4/7] vxlan: improve vxlan route lookup checks.
Date: Thu, 10 Nov 2016 10:56:39 +0100 [thread overview]
Message-ID: <20161110105639.6e8b70f7@griffin> (raw)
In-Reply-To: <CAOrHB_BwcJ0K3YcqPrVkKxFjWX9DFT1NjS3BbrcNtKQ_p_y44w@mail.gmail.com>
On Wed, 9 Nov 2016 19:34:06 -0800, Pravin Shelar wrote:
> Why it would not help in non-ovs vxlan egress path? It avoids checking
> (if condition) for device loop.
I may be missing something but I count the same number of conditions
for each packet, they're just at a different place after the patch.
E.g. for IPv4, the "if (!sock4)" is moved from vxlan_xmit_one into
vxlan_get_route and the "rt" error handling stays logically the same
(three if conditions in the non-error path) but is moved into
vxlan_get_route. Similarly for IPv6.
Jiri
next prev parent reply other threads:[~2016-11-10 9:56 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-05 18:45 [PATCH net-next v2 0/7] vxlan: General improvements Pravin B Shelar
2016-11-05 18:45 ` [PATCH net-next v2 1/7] vxlan: avoid vlan processing in vxlan device Pravin B Shelar
2016-11-06 9:57 ` Sergei Shtylyov
2016-11-09 16:04 ` Jiri Benc
2016-11-05 18:45 ` [PATCH net-next v2 2/7] vxlan: simplify exception handling Pravin B Shelar
2016-11-09 16:10 ` Jiri Benc
2016-11-10 3:33 ` Pravin Shelar
2016-11-10 9:47 ` Jiri Benc
2016-11-10 18:10 ` Pravin Shelar
2016-11-10 18:33 ` Jiri Benc
2016-11-10 19:21 ` Pravin Shelar
2016-11-11 11:14 ` Jiri Benc
2016-11-11 23:24 ` Pravin Shelar
2016-11-05 18:45 ` [PATCH net-next v2 3/7] vxlan: avoid checking socket multiple times Pravin B Shelar
2016-11-09 16:16 ` Jiri Benc
2016-11-09 16:34 ` Jiri Benc
2016-11-10 3:33 ` Pravin Shelar
2016-11-05 18:45 ` [PATCH net-next v2 4/7] vxlan: improve vxlan route lookup checks Pravin B Shelar
2016-11-09 16:41 ` Jiri Benc
2016-11-10 3:34 ` Pravin Shelar
2016-11-10 9:56 ` Jiri Benc [this message]
2016-11-10 18:10 ` Pravin Shelar
2016-11-10 18:37 ` Jiri Benc
2016-11-05 18:45 ` [PATCH net-next v2 5/7] vxlan: simplify RTF_LOCAL handling Pravin B Shelar
2016-11-09 16:53 ` Jiri Benc
2016-11-10 3:34 ` Pravin Shelar
2016-11-05 18:45 ` [PATCH net-next v2 6/7] vxlan: simplify vxlan xmit Pravin B Shelar
2016-11-09 16:59 ` Jiri Benc
2016-11-10 3:35 ` Pravin Shelar
2016-11-10 10:08 ` Jiri Benc
2016-11-05 18:45 ` [PATCH net-next v2 7/7] vxlan: remove unsed vxlan_dev_dst_port() Pravin B Shelar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161110105639.6e8b70f7@griffin \
--to=jbenc@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@ovn.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).