[PATCH] debugfs: improve formatting of debugfs_real_fops()

[PATCH] debugfs: improve formatting of debugfs_real_fops()

[Jakub Kicinski]

Type of debugfs_real_fops() is longer than parameters and
the name, so there is no way to break the declaration nicely.
We have to go over 80 characters.

Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
---
 include/linux/debugfs.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/include/linux/debugfs.h b/include/linux/debugfs.h
index bf1907d96097..374c6c67e6c0 100644
--- a/include/linux/debugfs.h
+++ b/include/linux/debugfs.h
@@ -52,8 +52,7 @@ struct debugfs_regset32 {
  * Must only be called under the protection established by
  * debugfs_use_file_start().
  */
-static inline const struct file_operations *
-debugfs_real_fops(const struct file *filp)
+static inline const struct file_operations *debugfs_real_fops(const struct file *filp)
 	__must_hold(&debugfs_srcu)
 {
 	/*
-- 
1.9.1

Re: [PATCH] debugfs: improve formatting of debugfs_real_fops()

[Greg Kroah-Hartman]

On Thu, Nov 10, 2016 at 05:23:49PM +0000, Jakub Kicinski wrote:
> Type of debugfs_real_fops() is longer than parameters and
> the name, so there is no way to break the declaration nicely.
> We have to go over 80 characters.
> 
> Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
> ---
>  include/linux/debugfs.h | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

[PATCH net-next] debugfs: improve formatting of debugfs_real_fops()

[Jakub Kicinski]

Type of debugfs_real_fops() is longer than parameters and
the name, so there is no way to break the declaration nicely.
We have to go over 80 characters.

Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
Sorry, I forgot to include the target tree in the tag, resending.
This is fixup for a patch which is sitting in net-next.

 include/linux/debugfs.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/include/linux/debugfs.h b/include/linux/debugfs.h
index bf1907d96097..374c6c67e6c0 100644
--- a/include/linux/debugfs.h
+++ b/include/linux/debugfs.h
@@ -52,8 +52,7 @@ struct debugfs_regset32 {
  * Must only be called under the protection established by
  * debugfs_use_file_start().
  */
-static inline const struct file_operations *
-debugfs_real_fops(const struct file *filp)
+static inline const struct file_operations *debugfs_real_fops(const struct file *filp)
 	__must_hold(&debugfs_srcu)
 {
 	/*
-- 
1.9.1

Re: [PATCH] debugfs: improve formatting of debugfs_real_fops()

[Greg Kroah-Hartman]

On Thu, Nov 10, 2016 at 05:23:49PM +0000, Jakub Kicinski wrote:
> Type of debugfs_real_fops() is longer than parameters and
> the name, so there is no way to break the declaration nicely.
> We have to go over 80 characters.
> 
> Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
> ---
>  include/linux/debugfs.h | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Doesn't apply to my tree, what did you make this against?

thanks,

greg k-h

Re: [PATCH] debugfs: improve formatting of debugfs_real_fops()

[Jakub Kicinski]

On Tue, Nov 29, 2016 at 11:58 AM, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> On Thu, Nov 10, 2016 at 05:23:49PM +0000, Jakub Kicinski wrote:
>> Type of debugfs_real_fops() is longer than parameters and
>> the name, so there is no way to break the declaration nicely.
>> We have to go over 80 characters.
>>
>> Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
>> ---
>>  include/linux/debugfs.h | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> Doesn't apply to my tree, what did you make this against?

net-next, sorry, it

Fixes: 68f929ff2654 ("debugfs: constify argument to debugfs_real_fops()")

I think that change still haven't propagated out of Dave's tree.  Dave
didn't take my fix up patch, though, so my plan was to resend it to
you during the merge window?  Would that make sense?

Re: [PATCH] debugfs: improve formatting of debugfs_real_fops()

[Greg Kroah-Hartman]

On Tue, Nov 29, 2016 at 12:11:37PM -0800, Jakub Kicinski wrote:
> On Tue, Nov 29, 2016 at 11:58 AM, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> > On Thu, Nov 10, 2016 at 05:23:49PM +0000, Jakub Kicinski wrote:
> >> Type of debugfs_real_fops() is longer than parameters and
> >> the name, so there is no way to break the declaration nicely.
> >> We have to go over 80 characters.
> >>
> >> Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
> >> ---
> >>  include/linux/debugfs.h | 3 +--
> >>  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > Doesn't apply to my tree, what did you make this against?
> 
> net-next, sorry, it
> 
> Fixes: 68f929ff2654 ("debugfs: constify argument to debugfs_real_fops()")
> 
> I think that change still haven't propagated out of Dave's tree.  Dave
> didn't take my fix up patch, though, so my plan was to resend it to
> you during the merge window?  Would that make sense?

Sure, that will work.

thanks,

greg k-h